Walletwasabi: [v1.1.11] Load HardwareWallet error when wallet already opened

[kravens]

General Description

When loading a Hardware Wallet from the Wallet Manager when a corresponding wallet is already opened via the Wallet Explorer, the following error message is given: "InvalidOperationException: State must be uninitialized. Current state: Started".
This could give a more clear message, like: "Hardware Wallet already loaded".
New users won't encounter this if they have no previously imported/loaded HardwareWallet xpub key.

How To Reproduce?

1. Go to 'Wallet Manager'
2. Click on 'Hardware Wallet'
3. Connect HardwareWallet (I used Ledger Nano S) to PC
4. Double click/open corresponding wallet in Wallet Explorer
5. Search Hardware Wallets
6. Click 'Load Wallet' after selecting the found HW-device
7. See error message

Screenshots

Operating System

Win10

Logs

https://github.com/zkSNACKs/WalletWasabi/issues/3396

Wasabi Version

1.1.11 release candidate.

[RiccardoMasutti]

This is normal behaviour. The wallet is already started

[RiccardoMasutti]

There are plenty of errors like this one inside the program. I reported a lot of errors like this and we discussed about optimizing the text.

Maybe we should count them as code optimizations instead of bugs, what do you think about it? @molnard @lontivero @nopara73

If you say yes, I am ready to send you about ten similar alerts, which could be optimized

[lontivero]

It is incredibly ugly.

[MaxHillebrand]

There was an ongoing effort to beautify the notification messages. This should be applied consistently. However, it is not priority for the release.

@RiccardoMasutti maybe you can make a PR fixing it afterwards?

[RiccardoMasutti]

There was an ongoing effort to beautify the notification messages. This should be applied consistently. However, it is not priority for the release.

@RiccardoMasutti maybe you can make a PR fixing it afterwards?

Sure!

[molnard]

I agree this should be fixed - not critical.

1 point.

[stale[bot]]

This has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[MaxHillebrand]

Fixed by #4217?

[stale[bot]]

This has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale[bot]]

This has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[molnard]

This GUI will be removed with WW2.0.