Walletwasabi: Add notification when too many coins registered

Created on 17 Feb 2020  路  7Comments  路  Source: zkSNACKs/WalletWasabi

Problem

currently when more than 7 coins are registered for the CoinJoin, then the error notification shows that there are not sufficient funds selected for the mix. Although this is correct, it is misleading the user as it does not tell about the too many coins.

Solution

Add a notification that is thrown when more than 7 coins are registered, and that says

Error!
You can only register up to 7 coins.
UI featurenhancement good first issue

Most helpful comment

Note that the coinjoining code will be replaced within a year with a new mixing tech's implementation. Why it's important is because it enables us to do solutions that normally we'd break hands and cut programming licenses for.

All 7 comments

ACK

I was about to open an issue about "Not sufficient funds selected". That notification is definitely needed

@garceri this notification you want is already implemented.

To be clear.
If there are more than 7 coins, who in total sum up to above the minimum denomination, but where any subsection of 7 coins do not sum to the minimum, then a notification should be thrown Error! You can only register up to 7 coins..

If there are less than 7 coins that sum to below the minimum, then the current notification of Not sufficient funds selected is good and can remain.

To be clear.
If there are more than 7 coins, who in total sum up to above the minimum denomination, but where any subsection of 7 coins do not sum to the minimum, then a notification should be thrown Error! You can only register up to 7 coins..

If there are less than 7 coins that sum to below the minimum, then the current notification of Not sufficient funds selected is good and can remain.

Thx for info. I'm working on it 馃挭

Note that the coinjoining code will be replaced within a year with a new mixing tech's implementation. Why it's important is because it enables us to do solutions that normally we'd break hands and cut programming licenses for.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

the-metalworker picture the-metalworker  路  3Comments

gabridome picture gabridome  路  3Comments

davterra picture davterra  路  3Comments

nopara73 picture nopara73  路  3Comments

MaxHillebrand picture MaxHillebrand  路  3Comments