Walletwasabi: [1.1.10] Save QR Code function bug

[ghost]

| PR | Description | Win | Mac | Lin |
|---|---|---|---|---|
| 13 | Save the image of QR code. | WIP | X | WIP |

General Description

No image has been saved after clicking on the Save QR Code right click menu and after that the "Save QR Code" option is greyed out for all the new generated addresses, not only for the initial one.

How To Reproduce?

1. I generated a new receive address and then I saw the related QR Code
2. Clicking on it with the right click I chose the "Save QR Code" option
3. A file manager windows appeared and I chose to save the image on the Desktop
4. However, no image has been saved on the Desktop
5. Also, then the "Save QR Code" option is greyed out for all the new generated addresses, not only for the initial one

Screenshots

Operating System

macOS Catalina v10.15.1

[davterra]

Cannot reproduce using ubuntu 19.04.

[molnard]

Is there an error in the log?

[nopara73]

I added it to the painful issues with the note that if it can be reproduced reliably or not.

[nopara73]

Cannot reproduce on Windows 10.

[ghost]

Is there an error in the log?

This is what I see when I try to save the QR Code.

```2019-12-08 11:56:45 INFO Global (809) AddressManager is saved to /Users/[user]/.walletwasabi/client/AddressManager/AddressManagerMain.dat.
2019-12-08 11:56:45 INFO Global (822) Nodes are disposed.
2019-12-08 11:56:45 INFO Global (847) TorManager is stopped.
2019-12-08 11:56:45 INFO Global (855) AsyncMutex(es) are stopped.
2019-12-08 11:56:45 INFO Program (62) Wasabi GUI stopped gracefully (46aaafba-2fc0-424a-93b6-460468a13724).

2019-12-08 11:56:51 INFO Program (44) Wasabi GUI started (58a14a6c-3c34-4fc4-ba5f-8d813ce50939).
2019-12-08 11:56:54 INFO Global (158) Config is successfully initialized.
2019-12-08 11:56:54 INFO TransactionStore (28) MempoolStore.InitializeAsync finished in 23 milliseconds.
2019-12-08 11:56:54 INFO TransactionStore (28) ConfirmedStore.InitializeAsync finished in 10 milliseconds.
2019-12-08 11:56:54 INFO AllTransactionStore (27) InitializeAsync finished in 28 milliseconds.
2019-12-08 11:56:54 INFO TorProcessManager (249) Starting Tor monitor...
2019-12-08 11:56:54 INFO Global (220) TorProcessManager is initialized.
2019-12-08 11:56:54 INFO TorProcessManager (66) Tor is already running.
2019-12-08 11:56:54 INFO Global (387) Loaded AddressManager from /Users/[user]/.walletwasabi/client/AddressManager/AddressManagerMain.dat.
2019-12-08 11:56:54 INFO MainWindow.xaml (74) UiConfig is successfully initialized.
2019-12-08 11:56:57 INFO IndexStore (43) InitializeAsync finished in 2 seconds.
2019-12-08 11:56:57 INFO BitcoinStore (39) InitializeAsync finished in 2 seconds.
2019-12-08 11:56:57 INFO HostedServices (49) Stared Software Update Checker.
2019-12-08 11:56:57 INFO Global (329) Start connecting to nodes...
2019-12-08 11:56:57 INFO Global (351) Start synchronizing filters...
2019-12-08 11:56:59 INFO Global (691) Wallet loaded: Wallet0.
2019-12-08 11:56:59 INFO ClientState (468) Round (12332) added.
2019-12-08 11:56:59 INFO ClientState (468) Round (12333) added.
2019-12-08 11:56:59 INFO Global (475) Start Chaumian CoinJoin service...
2019-12-08 11:56:59 INFO Global (477) Starting WalletService...
2019-12-08 11:56:59 INFO CoinJoinClient (141) CoinJoinClient is successfully initialized.
2019-12-08 11:57:02 INFO Global (479) WalletService started.
2019-12-08 11:57:29 INFO ClientState (450) Round (12332) removed. Reason: It's not running anymore.
2019-12-08 11:57:29 INFO ClientState (468) Round (12334) added.
```

[ghost]

@nopara73 At least with macOS Catalina this is totally reproducible in a reliable way. Not tried with the other OS.

[danwalmsley]

ACK I will take this one!

[MaxHillebrand]

Yes, saving it to desktop does not work on MAC, thus it breaks the feature.
2 points

[danwalmsley]

OK this was caused by swallowed exception in OSX and is fixed here:
https://github.com/AvaloniaUI/Avalonia/pull/3343

A new RC will be required for Avalonia

[molnard]

It will display the exception in a notification from now. For example on windows defender blocked the save of the file.