Walletwasabi: [1.1.10] Transaction Broadcaster should copy from clibboard based on lenght

Created on 6 Dec 2019  Â·  6Comments  Â·  Source: zkSNACKs/WalletWasabi

PR | Description | Win | Mac | Lin
-- | -- | -- | -- | --
1 | Transactions test: create transactions, send/receive, create PSBT, broadcast it. |   |   | ✗

Transaction Broadcaster should copy from clipboard based on characters lenght.
PSBT or Transaction Hex > Click here to copy from clipboard

By reading this, I assume Wasabi will paste only PSBT or Tx Hex; instead it paste anything without exclusions.
A good idea would be to paste only clipboards > X characters on this tab. For example > 34 characters (an address is 34 characters long)
should-copy-only-based-on-lenght

questioresearch

All 6 comments

I think this is not an issue.

I agree it is an improvement. What should be the minimum size and why? How short is the shortest PSBT?

I'd prefer to ACK it, but the implementation can be tricky from a performance point of view. (Or not :)

Not a bug report, but a feature request [kinda?]

So I think it's 0 points, but can be 1 if @molnard thinks so...

Note, in order to make it future proof we need to take the length of a txid as minimum, since that's something (I don't remember if I implemented already) but will be implemented to paste txid, query the tx over Tor and rebroadcast it/make sure your wallet knows about the tx.

Transaction Broadcaster tab was changed. #3859 #3871

Was this page helpful?
0 / 5 - 0 ratings

Related issues

RiccardoMasutti picture RiccardoMasutti  Â·  3Comments

UkolovaOlga picture UkolovaOlga  Â·  3Comments

molnard picture molnard  Â·  3Comments

MaxHillebrand picture MaxHillebrand  Â·  3Comments

MaxHillebrand picture MaxHillebrand  Â·  3Comments