Walletwasabi: Dispose ManualResetEventSlim

Created on 2 Oct 2019  路  5Comments  路  Source: zkSNACKs/WalletWasabi

private readonly ManualResetEventSlim Mre = new ManualResetEventSlim();

In SingleDisposable.cs Mre is never disposed.

debug stale

All 5 comments

In RegTestFixture.cs class.

BackendNodeBuilder = NodeBuilder.CreateAsync(EnvironmentHelpers.GetMethodName()).GetAwaiter().GetResult();

Disposable object created by 'NodeBuilder.CreateAsync(EnvironmentHelpers.GetMethodName())' is never disposed.

In CoinJoinClient.cs

aliceClient = await AliceClient.CreateNewAsync(inputRegistrableRound.RoundId, registeredAddresses, schnorrPubKeys, requesters, Network, outputAddresses.change.GetP2wpkhAddress(Network), blindedOutputScriptHashes, inputProofs, CcjHostUriAction, TorSocks5EndPoint).ConfigureAwait(false);

Capture44

The latter is disposed, it's just VS cannot tell when I think. Nevertheless a better pattern would be more reasonable to use.

This has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@nopara73 Both of the cases that I mentioned are no longer present because the code changed.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

yahiheb picture yahiheb  路  3Comments

MaxHillebrand picture MaxHillebrand  路  3Comments

MaxHillebrand picture MaxHillebrand  路  3Comments

trading2835 picture trading2835  路  3Comments

UkolovaOlga picture UkolovaOlga  路  3Comments