Walletwasabi: Qubes clipboard issues

[MaxHillebrand]

General Description

Specifically in Qubes operating system, the clipboard does not work. I can neither copy, nor paste information in the wallet.

How To Reproduce?

1. Go to Receive
2. Click on the address to auto-copy
3. Try to paste in Send with Ctrl + V,
4. see error, it is not in the wasabi-qube clipboard
5. In the Receive, click address and press Ctrl + Shift + C to try to get it in the dom0 clipboard
6. Try to paste in Send with Ctrl + Shift + V & Ctrl + V, see error, it is not in the dom0 clipboard

Operating System

I believe that this issue is for Qubes OS specifically, I have only tested in qubes v4.0.2 a Debian v9 qube. The clipboard seems to be somewhat messed up in both v1.1.6 and master.

Review

As far as I can remember, @kixunil and @davterra have the same issue in qubes. Maybe they can describe the issue more adequately?

[nidkil]

Are you copying between domains? If so, did you first copy to the global clipboard and then to the other domain clipboard?

[MaxHillebrand]

Yes, and no.
For example, when I copy in the Receive tab, and want to paste in the Send tab, then in previous versions I had to move it to the global clipboard. Now I can't even do this, it just won't paste in Receive.
Also when I copy in the Receive and want to paste in the same VM in another application - there I also needed to do Ctrl + Shift + C/V to get it out, now this is no longer working either.
And finally the same issue when moving to another VM,

[davterra]

My situation is the same as what @MaxHillebrand has described. Additionally, running Debian9 inside of Qubes4.02, when I click on the "view password" icon nothing happens. The function does not work in my setup.

[MaxHillebrand]

This also brings to mind that when expanding the top menu, the list buttons are not clickable, at least sometimes... Might be the same issue as you describe?

[davterra]

Ok, I've been running 2 different wasabi wallets on 2 different debian9 vm's on Qubes (both vm's standalone, not template). Today, after updating each install to commit: 0c356f, I find that the copy/paste issue seems to have disappeared. I am able to copy/paste testnet addresses between the 2 vm's with no problem. HOWEVER, as @MaxHillebrand mentioned, there still seems to be issues with the top menu pulldown items, in terms of them not working when clicked on, or if the pulldown "covers" a different clickable item on the main interface and I click on the pulldown menu, it activates the "underlying" main interface item.
Also, the "show password" icon does nothing when clicked on

[davterra]

Follow up: After more testing on both of the aforementioned VM's I've noticed that, on either, if I exit Wasabi and restart, the pulldown menus work for a few minutes, then stop working. I will continue variations on what I do using the wallet during those few minutes to see if the problem arises consistently around the same usage-time along with with trying to see if a specific function-usage causes the problem.

[MaxHillebrand]

Typo, you probably mean commit 0c356fea.

I can confirm, I can paste again! But the click-to-paste seems still not to work when I copy an address from external qube, but when I copy my own receiving address in the wallet, and paste it in the same wallet, then the click works.

I can confirm your description of the top menu issue - I did not know before that it was related to uptime, but it seems you are correct!

[MaxHillebrand]

Interestingly, I could not reproduce the clipboard issue here... https://github.com/zkSNACKs/WalletWasabi/issues/2079

[davterra]

Yes, I can definitely now copy/paste to/from external vm's.
Are your "view password" icon/functions working in your setup? They do not work for me.
I have yet to experiment with issue #2079. Will try to get to that soon

[MaxHillebrand]

Can confirm, view password does not work.

[Kixunil]

Don't have much time to look into it, but here's a hint: there are three clipboards in Linux: primary, secondary, clipboard. Maybe different ones are used by Qubes copy and Wasabi.

If you want to play with it there's a handy command line tool called xsel which you can use to inspect and manipulate these clipboards. See the man page. sudo apt-get intstall xsel should work. :)

[MaxHillebrand]

Avalonia 9 fixed this

You can work around it by putting it into dom0 clipboard with Ctrl + C in the Receive tab - then Ctrl + V in the Send tab.

[MaxHillebrand]

I am encountering this problem again, both on 1.1.10.2 and on master.

[kekekeks]

@MaxHillebrand

Please, run
xclip -o -selection clipboard and xclip -o -selection clipboard -t TARGETS in Wasabi VM after copying text from Wasabi

[MaxHillebrand]

@kekekeks, these are on master branch

~$ xclip -o -selection clipboard
dc54d3f085bdc42ead6dee85d8cedf39974a24d803f77b880e8b25f838a64917

~$ xclip -o -selection clipboard -t TARGETS
STRING
UTF8_STRING
TARGETS
MULTIPLE
 ```

these are on v1.1.10.2

$ xclip -o -selection clipboard
Error: target STRING not available

$ xclip -o -selection clipboard -t TARGETS
TIMESTAMP
TARGETS
MULTIPLE
SAVE_TARGETS
UTF8_STRING
COMPOUND_TEXT
TEXT
STRING
text/plain;charset=utf-8
text/plain
```

[MaxHillebrand]

I have tested it again.
The issue is definitely present in v1.1.10.2, here I cannot even copy and paste within the same Wasabi instance - if I copy an address in the receive tab, I cannot paste it in the send tab.
However, on master branch 0931e2d9c11928fedf92e7a316da01595c306c63 it works, in all cases, exactly how it should.

I'm really confused now, as I thought it did not work on master... But apparently my memory is mistaken.

I'm closing the issue, until I encounter the issue on master branch again.

[MaxHillebrand]

Further, it is fixed on the backport branch at 95b15afe4ac8ff63f97143b6af00d4529d555a47.
I will test if it is fixed in the next silent release too.

For what it's worth... it also works on this bleeding edge release of 1.1.10.2 which has the macOS signing.

[MaxHillebrand]

It is also fixed in release 1.1.10.3 .

[jmacato]

@MaxHillebrand that's weird... I wonder if it's worth looking at it with git bisect just to pinpoint exactly what commit made it work again.

[MaxHillebrand]

I'm very frustrated, because I have to re-open this issue for like the 5th time now...

When I build the backport branch at d018d8278356a57049c9114ed61c82bc9ebb7268, or when I checkout v1.1.10.3, also when I do dotnet run -c Release, I can copy from Wasabi VM, and paste in another VM. I can copy in another VM, and paste in Wasabi VM.

However, when I install the package v1.1.10.3 [which is exactly the same as backport d018d8278356a57049c9114ed61c82bc9ebb7268], then I can neither copy from Wasabi VM and paste in another VM, nor copy from another VM and paste in Wasabi VM.

So, it seems that there is an odd issue that happens during the packaging...

[Kixunil]

That's strange, is it the Debian package that is problematic or something else?

[MaxHillebrand]

IDK @Kixunil ... I'm running the debian package.

[Kixunil]

Did you try to compare them in the same Qube? (from same template)

Maybe the most sure thing to do is run a DVM, install package, test, kill, run another DVM based on the same template, build and test, kill.

[MaxHillebrand]

I have one template for building source [with the .NET stuff] and use for package [straight debian 10].
If I compile in the packaged vm, then the issue is not present.
If I install package in the building vm, then again, there is the issue.
So, regardless which vm I use, the package has a broken clipboard...

[Kixunil]

Maybe another good test: try to compile it, test that it works, then try creating the package yourself and test the package (could be something different between machines).

[MaxHillebrand]

Ok, I am baffled and do not know why. but now it works in all cases, both compiling master c9f4d1cd78eb320ab9c40fb8fd685fa8f9695153 and the packaged v1.1.11RC2.

Anyhow, I will close the issue for now, and re-open [for like the 5th time] if I encounter it again...

[Rudd-O]

This is not fixed. Please reopen this. This continues to happen with the very latest release, even with that release containing later versions of Avalonia. Copying anything from Wasabi textboxes does not fill any of the system clipboards, and pasting from any system clipboards does not work either. Not being able to copy and paste seems critical since it exposes the user to typos as he has to retype complicated information. Thanks.

I am running the tarball, not the Debian package, under a Fedora 32 instance within Qubes. For the record, I do not think Qubes has anything to do with the problem because the copy and paste issue isn't an inter-VM copy and paste issue — it does not work even within the same VM between apps, and even within Wasabi text boxes themselves.

[Rudd-O]

I have confirmed that Wasabi's copy and paste does not work in a fresh disposable VM either.

[lontivero]

What version of Wasabi are you using?

[MaxHillebrand]

@Rudd-O that's odd, I cannot reproduce the issue any more.

Could you maybe try how it works in the latest Fluent UI work? [build master branch source, not yet released.]
cd WalletWasabi/WalletWasabi.Fluent.Desktop && dotnet run

[Rudd-O]

@lontivero latest published version.

@MaxHillebrand I will try and build myself. Wish me luck.