Walletwasabi: [Bug] Invalid Host for torv3

[NicolasDorier]

General Description

How To Reproduce?

Put a Torv3 onion link.

This work on the latest release, not on master.

[NicolasDorier]

public string ValidateHost(string host)
        {
            if (string.IsNullOrWhiteSpace(host))
            {
                return string.Empty;
            }

            var theHost = host.Trim();
            if (Uri.TryCreate(theHost, UriKind.Absolute, out _))
            {
                return string.Empty;
            }
            if (IPAddress.TryParse(theHost, out var ip))
            {
                if (ip.AddressFamily == AddressFamily.InterNetworkV6 && !Socket.OSSupportsIPv6)
                {
                    return "OS does not support IPv6 addresses.";
                }
                return string.Empty;
            }

            return "Invalid host.";
        }

This is wrong. This can't be an URL.

[NicolasDorier]

Ok you are complicating the logic way too much... will fix this.

[nopara73]

Aaah, there were so many pull request and issues on hold I didn't get to this one. Fixing this should've go into the release.

[NicolasDorier]

@nopara73 https://github.com/zkSNACKs/WalletWasabi/pull/1739

[NicolasDorier]

I added the support of bitcoin-p2p uri, this is used in green wallet, knots and btcpay