Walletwasabi: Drop BTC price info from status bar

[xavierfiechter]

Why?

• $ = USD?
• 1 BTC = 1 BTC
• It's inaccurate
  
  

[nopara73]

If it's inaccurate, shouldn't the solution be to fix it?:)

Btw what would be the best source to fetch it from? Some kind of average.

[xavierfiechter]

I suggested already in https://github.com/zkSNACKs/WalletWasabi/issues/1369#issuecomment-490609413 to drop the price before noticing that it's inaccurate.

Maybe https://bitcoinaverage.com/de/bitcoin-price/btc-to-usd, there is an API for get various fiat pairs.

[nopara73]

For the record, the related API call is: https://apiv2.bitcoinaverage.com/convert/global?from=BTC&to=USD&amount=1

[xavierfiechter]

Others have issues as it seems: https://www.reddit.com/r/WasabiWallet/comments/byqyw2/price_in_wasabi_not_updating/

[nopara73]

Seems like SmartBit gets stuck once in a while. Deploying BitcoinAverage now.

[xavierfiechter]

Could you please add USD instead of just $ if you intend to keep the price in the status bar?

[nopara73]

It's not ambiguous.

[xavierfiechter]

Dollar (often represented by the dollar sign $) is the name of more than 20 currencies, including those of Australia, Canada, Hong Kong, Jamaica, Liberia, Namibia, New Zealand, Singapore, Taiwan, and the United States.

from https://en.wikipedia.org/wiki/Dollar

[nopara73]

The context is clear. Everyone knows what's the price of Bitcoin in USD, so based on the number it's instantly recognizable. Sure it's not Bitcoin politically correct, and hopefully we won't even price Bitcoin in $ in the future anymore, but at the time and place we're at, in History, it's not ambiguous, it's practical and it's useful.

For example Bitcoin means some people Bitcoin SV or Bitcoin Cash, yet even they understand that in this very comment I'm talking about Bitcoin and not the forks.