Wails: Windows Packaging Broken

[Pierre-Felber]

With the changed windows icon generation, observed by me in 1.6.0 (I've updated from 1.0.2), packaging in windows is broken:

Icon created is now $APPNAME.exe.ico
Icon referenced in RC template is still $APPNAME.ico see
notice the new exe part

This leads to a failing winres call in the resource step.

The project cleanup step after build is also still using the old $APPNAME.ico, therefore after successful build
_(only possible with modified RC template or manually created symlink $APPNAME.ico to $APPNAME.exe.ico)_
the $APPNAME.exe.ico is left in the project instead of being deleted. (The symlink $APPNAME.ico gets deleted, as per old behavoir )

I am surprised this bug made it into a release. Seems there is no test for wails build -p on windows.

[leaanthony]

Hi. Thanks for raising this. Testing is pretty hard and a lot of it is done manually. We rely on feedback of the -pre branches for releases and this is the first time this has been raised. @dedo1911 would be the first person to be able to respond to this. I'll take a look today also.

[dedo1911]

The icon shouldn't be $APPNAME.exe.ico but just $APPNAME.ico instead.
I'll take a better look at it tomorrow.

[dedo1911]

@Pierre-Felber can you please check out your project.json file

I think you have:
"binaryname": "appname.exe",

That should be:
"binaryname": "appname",

I think we might better add some checks about it, but that might be the issue at the moment for you

[leaanthony]

There's a potential fix on develop. About to test. Project name shouldn't matter, but yeah could be a migrate issue.

[Pierre-Felber]

@Pierre-Felber can you please check out your project.json file

I think you have:
"binaryname": "appname.exe",

That should be:
"binaryname": "appname",

I think we might better add some checks about it, but that might be the issue at the moment for you

Yes, you are correct: project.json has "binaryname": "appname.exe"
Changing it to "binaryname": "appname" resolves the issue.

Then it's a migration issue, isn't it? I just did wails update, not wails migrate

[leaanthony]

It's on us. There was a change a while back to normalise the project name to sans .exe for new projects. The only thing that has been affected is the icon generation that uses the project name regardless of exe. I've made that fix for the develop branch and I'm just testing.

But you're right, we should absolutely add this to wails migrate, though that was really for projects

Will keep.you posted!

[leaanthony]

@Pierre-Felber - I've tested the fix on Windows 10 and made it part of v1.7.0-pre1. Please update using wails update -pre and let us know if it works. If it does, I'll release it as v1.7.1 so it's part of the stable channel.

BTW: This testing also uncovered an issue with the vanilla template so thanks for raising it! 2 bugs fixed!

[Pierre-Felber]

@Pierre-Felber - I've tested the fix on Windows 10 and made it part of v1.7.0-pre1. Please update using wails update -pre and let us know if it works. If it does, I'll release it as v1.7.1 so it's part of the stable channel.

TX, can confirm it works with "binaryname": "appname.exe" in v1.7.0-pre2

Very fast fix, thanks!!!

[leaanthony]

@Pierre-Felber - this is now in v1.7.1. Feel free to get back on the stable release channel using wails update.