Vyper: Performance issue in event logging implementation
Judging by the code, event arguments that are not byte arrays are packed twice. 2nd packing rewrites the 1st packing. This adds complexity and affects gas consumption.
Related to https://github.com/ethereum/vyper/issues/730
denis-bogdanas
All 3 comments
@denis-bogdanas there is a specific reason though. We have two sections that need to be potentially packed. One Handles static part of the logging format, the next section packs the dynamic part ( for example if it's a bytearray).
https://solidity.readthedocs.io/en/develop/abi-spec.html#use-of-dynamic-types
jacqueswww
on 30 Mar 2018
Yes I know that. You only need to compute the size of static part in the first run, not to actually pack it. And it would be cleaner to just re-use the code for packing method parameters. The format is the same, and code for methods doesn't pack twice.
denis-bogdanas
on 31 Mar 2018
Thanks again for all the bugs vyper-semantics picks up ! :smile_cat:
jacqueswww
on 4 Apr 2018
Related issues
ben-kaufman
路
3Comments
michwill
路
3Comments
yudetamago
路
4Comments
jacqueswww
路
3Comments
fubuloubu
路
3Comments
Most helpful comment
Yes I know that. You only need to compute the size of static part in the first run, not to actually pack it. And it would be cleaner to just re-use the code for packing method parameters. The format is the same, and code for methods doesn't pack twice.