Vyper: Refactor conversion tests from `test_bytes` to `test_convert_bytes32` and `test_convert_bytes`

Created on 15 Nov 2018  路  4Comments  路  Source: vyperlang/vyper

Version Information

  • vyper Version: 0.1.0b4

What's your issue about?

Currently the tests for testing type conversion are spread across different files corresponding to either the type being converted from, or the type being converted to. This is a bit confusing for adding new functionality/reviewing the tests as it is unclear if the tests should be in the test file for the type being converted from or that being converted to.

How can it be fixed?

We create a new test file test_type_conversions.py in the types test directory and refactor all related type conversion tests to be located there.

Cute Animal Picture

image

Most helpful comment

Sounds good to me! Conversions are a feature, not a bug 馃ぃ

All 4 comments

Sounds good to me! Conversions are a feature, not a bug 馃ぃ

Rad, I'll do this after #1077, #1082, and #1085 are all ready for merge to avoid merge conflicts haha.

Works for me :+1:

Merged PR.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

robinsierra picture robinsierra  路  3Comments

vici0 picture vici0  路  3Comments

ben-kaufman picture ben-kaufman  路  4Comments

fubuloubu picture fubuloubu  路  3Comments

haydenadams picture haydenadams  路  3Comments