Vuesax: Buttton type gets ignored

[RickCardoso]

After the last update, the button type could be set manually overriding Vuesax default as "button". So we could set a button to be submit using:

<vs-button
    type="button"
   ...
</vs-button>

Now the type gets ignored and the button is always set as type="button". This makes forms stop working when the button calls the form submit.

• OS: Windows 10
• Node.js version: 8.11.2
• Vuesax version: vuesax3.1.7
• Browser version: Chrome 67.0.3396.87
• Package manager: npm v6.1.0

[luisDanielRoviraContreras]

Ready and the problem is solved when I upload you notice to review it I'm updating the select just finished upload the latest version with the arrangement thank you very much

[pitchinnate]

Also just noticed I think the changes to button recently messed up the Dialogs, Confirmations.

[pitchinnate]

Also it messed with buttons that an icon specified, all the sudden they now float left.

[luisDanielRoviraContreras]

You could pass images of the problems, thank you very much for the contribution the documents were updated

[luisDanielRoviraContreras]

You can now add the type property without problem please check thanks

[pitchinnate]

Here is how Dialogs look now:

[pitchinnate]

Also here is how adding an icon affects it:

Then with just adding vs-icon you get this:

[pitchinnate]

For now I've had to work around it by putting the icon in myself doing something like this:

<vs-button
          v-on:click="$emit('creator-click')"
          vs-color="success"
          vs-type="filled"
          class="addButton">
        <i class="material-icons">add_circle</i>
        {{creatorText}}
      </vs-button>

But it requires some more css changes to get the icon to be the right size and line up correctly.

[luisDanielRoviraContreras]

Do you have the latest version?

[pitchinnate]

I believe so I'll check.

[pitchinnate]

Ok that seemed to fix it I just did another upgrade. Any idea why material icons are broke now?

[pitchinnate]

Also the floating left on a button with a vs-icon still happens with latest upgrade.

[luisDanielRoviraContreras]

Library icons were removed now you have to add them independently

[luisDanielRoviraContreras]

but in the documents does not happen that if it's weird you could give me a repo or something to verify the problem and fix it

[pitchinnate]

Any quick instructions in docs for installing library icons?

[pitchinnate]

Nevermind I found I can just add

<link href="https://fonts.googleapis.com/icon?family=Material+Icons" rel="stylesheet">

to my index.html for now.

[luisDanielRoviraContreras]

If that is the idea, it is very easy to add it but it gave many problems in compilation and unnecessary loaders if you can add the documents on this in a RP would be great thanks

[pitchinnate]

Yeah I don't mind loading it from a CDN I'm loading other google fonts the same way I'm sure some people will want it locally downloaded but works fine for me. Yeah I can add it to the documentation.

[safiullahsarhandi]

<vs-button button="submit" color="success" type="gradient" class="float-right">Click Me </vs-button>
the default type of button is set to button which cause preventing submitting form add button="submit" to change the behavior with in form

[gautam-patadiya]

@safiullahsarhandi you save my day buddy thanks!