Vue-storefront: Incorrect update the qty of cart item

Created on 2 Dec 2019  路  6Comments  路  Source: DivanteLtd/vue-storefront

Current behavior

Update the qty - nothing to change. See only visually updated.
The Vuex state not updated.

Expected behavior

Update the qty from frontend - then check Vuex state changed.

Steps to reproduce the issue

Try to change the qty for some item in cart.

Repository

https://github.com/DivanteLtd/vue-storefront/blob/1fd1cf4414b65a049401c3a8011344f462de29cf/core/modules/cart/store/mutations.ts#L47

https://github.com/DivanteLtd/vue-storefront/blob/1fd1cf4414b65a049401c3a8011344f462de29cf/core/modules/cart/store/actions.ts#L578

dispatch('updateItem', { product: { qty: cartItem.prev_qty } })

Need pass the sku property to product option.

Can you handle fixing this bug by yourself?

  • [x] YES
  • [ ] NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • [ ] This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • [ ] This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • [ ] This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

  • Browser:
  • OS:
  • Node:
  • Code Version:

Additional information

Important VSF1 bug

All 6 comments

@dimasch Hey, could you tell us which version of VSF did you use?

I would like to take this issue

Hey @dimasch tested it on 1.11 branch and it works fine, but on 1.10 branch the getter returns different quantity as you have mentioned

ok so seems like we have to backport a bugfix thanks @georgiev-ivan

@andrzejewsky can we quickly fix this one and close it (the solution is provided in the comment)

@dimasch Hey :) I've check this in 1.10.6 and it seems working ok. Can you check if this still occurs?
Peek 2020-04-06 09-45

Was this page helpful?
0 / 5 - 0 ratings