Vue-storefront: Can't run docker-compose on latest master

Created on 5 Jun 2019  路  4Comments  路  Source: DivanteLtd/vue-storefront

Current behavior

Not possible to start a clean install from master branch in docker with docker-compose up

app_1  | ERROR in /var/www/core/lib/multistore.ts
app_1  | ./core/lib/multistore.ts
app_1  | [tsl] ERROR in /var/www/core/lib/multistore.ts(137,41)
app_1  |       TS2345: Argument of type 'object' is not assignable to parameter of type '{ [key: string]: unknown; }'.
app_1  |   Index signature is missing in type '{}'.
app_1  | 
app_1  | ERROR in /var/www/core/lib/search/adapter/api/searchAdapter.ts
app_1  | [tsl] ERROR in /var/www/core/lib/search/adapter/api/searchAdapter.ts(74,45)
app_1  |       TS2345: Argument of type 'HttpQuery' is not assignable to parameter of type '{ [key: string]: unknown; }'.
app_1  |   Index signature is missing in type 'HttpQuery'.

Expected behavior

The codebase should compile

Steps to reproduce the issue

  • Clone vue-storefront repo
  • Run installer
  • docker-compose up

Repository

https://github.com/DivanteLtd/vue-storefront

Can you handle fixing this bug by yourself?

  • [ ] YES
  • [x] NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

  • [ ] This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
  • [ ] This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
  • [x] This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

  • OS: Tested on OSX and with Travis
  • Node: 8
  • Code Version: e2c11b17cf44d761f268ae951685c11efc6bce7a

Additional information

Error to be seen at: https://travis-ci.org/benjick/vsf-docker-problem/builds/541617124#L592

bug

All 4 comments

could You heck it out @patzick please?

@benjick @patzick Looks like about the same issue as #3007 which was closed with a reference to pull request #3006. If my initial test is to be trusted, the same fix seem to resolve this issue as well.

Thanks @indiebytes! :) I will backport this with 1.9.2

Done, will be released with 1.9.2

Was this page helpful?
0 / 5 - 0 ratings