Vue-storefront: Test + Fix MS Edge + IE10 support

Created on 8 Jun 2018  路  11Comments  路  Source: DivanteLtd/vue-storefront

win7_ie_10 0
win10_ie_11 0
win10_edge_17 0

Nice to have bug help wanted vs-hackathon

All 11 comments

IE 10 support requires rewriting default theme, for edge everything except unsupported enhancements like mix-blend-mode for images works now

Has this been fixed? Recent deployment does not work at all in IE 11

@dennisotugo could You please test the newest version that's running on https://test.vuestorefront.io/?

There were some issues regarding Babel config - they're already solved

@pkarw edge is working, ie10 & ie11 seems broken.

OK, would be great to put all the required bugs on IE into issues and fix them one by one :)

Sorry for the late reporting on this. @pkarw Nearly all functionality does not work on IE11. Buttons don't work and Product Images does not show likewise. We can start with these ones.

@dennisotugo please do

I do some tests, but I am not a Webpack expert, so please correct me if I am wrong:

VSF is not working on IE11 & 10 because there is ES6 code that IE is not supporting.
2018-09-21_10h11_16

This code appears there because we don't compile ES6 code in node_module.

{
        test: /\.js$/,
        loader: 'babel-loader',
        include: [
          '@vue-storefront',
          path.resolve(__dirname, '../../src'),
          path.resolve(__dirname, '../../core')
        ]
      },

When I added the node_mode path to babel configuration... application exploded :D. After long hours of debugging and fixing webpack/babel problems, I ran VSF on IE.

2018-09-21_09h24_14

So, in my opinion, we should compile node_module code also. It would be great if someone with experience in webpack could check my theory and suggest the best method on how to fix this problem.

Good point! We should aim the modules that are not compiled with Babel by their creator (as this Vue-offline show. On screen - made by @filrak hah ;)) and add exceptions for them (to compile them by Babel)

@mdanilowicz do you have maybe a kind of list from your research which modules need to be fixed?

Could someone try to replace stage-2 with stage-3 in .babelrc config? I tried on my project (which however is a lot of versions behind) and it worked

@pkarw yeah right but there is a little bit more libs like this, we can provide a genera艂 solution for this. I like nuxt approach. They are allowing you to specify node modules to transpile in your package.json

Was this page helpful?
0 / 5 - 0 ratings