Vue-js-modal: Dialog: clickToClose should be false by default or configurable

Created on 25 Aug 2017  路  4Comments  路  Source: euvl/vue-js-modal

When presenting a dialog to a user, he has to choose from a set of given options. Being able to click the background to close the dialog in most cases makes no sense (at least in my opinion and use cases ;-) ). Another problem is, that I'm not able to attach a background-click-handler to cover that case. So I'd propose to either make this configurable (just like it is for a normal modal) or set it to false for dialogs.

enhancement todo

Most helpful comment

hey @alex3683,

i've added this feature, will be published in next version 馃憤

All 4 comments

Hi @alex3683,

Sorry that it takes me so long to reply, i think you are right, and making clickToClose, width and some other parameters configurable (not all of them though) would be a good idea.

I will be able to spend some time on it on the next weekends. Also, if you feel like you could do it, I will be happy to accept a PR.

Thanks.

hey @alex3683,

i've added this feature, will be published in next version 馃憤

Cool, thanks. Would have liked to do it as PR, but you surely know the problem of limited time ;-)

Absolutely, took me 20 days to add 5 lines of code >_____________<

Was this page helpful?
0 / 5 - 0 ratings

Related issues

mbalandis picture mbalandis  路  4Comments

smholsen picture smholsen  路  4Comments

Max64 picture Max64  路  4Comments

a3020 picture a3020  路  5Comments

whaoran picture whaoran  路  3Comments