Vue-js-modal: Vuejs loaded twice

[a3020]

dist/index.js contains vuejs 2.2.6.

If I use import vmodal from 'vue-js-modal'; in an existing vuejs project, vuejs is loaded twice because my main application uses version 2.3.3.

What is the general approach to overcome this? I am a ES6 noob, so sorry if this is dumb question :)

[euvl]

It is pretty good question, thanks for noticing it.
I think i should remove it from dependencies.

But i will need a help of webpack gugu to figure out how to correctly package it without included vuejs lib.The reason being is that without vuejs being "built in" es5 build fails.

[a3020]

Yeah, I don't think it's common to have it included in dist. From what I read you need to use path.resolve. See e.g. https://github.com/webpack/webpack/issues/2134#issuecomment-192579511 and http://stackoverflow.com/questions/31169760/how-to-avoid-react-loading-twice-with-webpack-when-developing.

[euvl]

Hey @a3020, I think I've done it 😄
If you will check the latest master, it has a ±30 kb dist/index.js (instead of a bloody ±300kb) and it seems to work as it used in the demos.

Would you have time to test whether it works for your project?
(keep in mind its not on npm yet, only on github)

[a3020]

I used npm install --save-dev git+ssh://[email protected]/euvl/vue-js-modal to install directly from the Github repo. I then ran webpack. All still works and vue-js is only loaded once. So yes, I think you nailed it 👍

[euvl]

Great, thanks a lot for your help! 👍 🥇
Will do a new release now!