Vue-devtools: Causes Firefox to not display XML tree

[jmsfwk]

When reading a plain XML file Firefox displays the XML tree.

When vue-devtools is enabled it only shows the text nodes.

[jpicton]

Well that explains it. Been trying to figure out which one of my Firefox addons was disrupting the XML tree view.

[yyx990803]

@clarkbw would you be able to look into this or point us to someone that might know what's going on?

[clarkbw]

I’ve seen this before I think. Something about the detection breaks the XML view. @digitarald might know more about how to track this down.

[digitarald]

I am asking around, hopefully got somebody to check this tomorrow.

[rpl]

@digitarald I looks that this issue has been already fixed in #385 by checking if the document is instanceof HTMLDocument before injecting a tag script into the document:

https://github.com/vuejs/vue-devtools/blob/472f3c67200bd70853bc5a93c401cbe9b46fc00f/shells/chrome/src/detector.js#L31-L36

I build the extension from this repo master branch and I confirm that, with the above fix, the XML viewer is rendered as expected on XML documents loaded into Firefox.

The version of vue-devtools on AMO doesn't include this fix yet.

[prog-rajkamal]

As this issue is already fixed. any idea how soon can we expect an updated version of Vuejs devtools on AMO?

[prog-rajkamal]

It seems @yyx990803 has updated the extension. The issue no longer occurs. So this issue can now be closed.

Verified this on FF 56.

[yyx990803]

Lol double close!

[Akryum]

😹