Vscode: Toogle simple full screen very slow since electron 4 update

[isidorn]

macOS

Have the following setting
"window.nativeFullScreen": false
F1 > toggle full screen

Wait for 2 seconds -> the screen is full screen.
I can repro 100% of time.

Can not repro with stable, so I think electron 4 is to blame.

[bpasero]

@deepak1556 this looks awfully similar to the native tabs issue, can you check?

[deepak1556]

I was able to repo with minimal electron app in 4.x , but it does seem fixed with 5.x and higher. I will try to narrow down the fix

const {app, BrowserWindow} = require('electron')

app.on('ready', () => {
  win = new BrowserWindow({
    fullscreenable: false
  })

  win.loadURL('https://google.com')

  win.webContents.on('did-finish-load', () => {
    win.setSimpleFullScreen(true)
  })
})

[bpasero]

I have pushed a change to disable support for simple fullscreen for now. We can bring it back after Deepaks fix ends up in a release. I also added the setting to the collection of settings keys we track for telemetry.

[Tsmith18256]

Is there any other way to enable this functionality in 1.36? I understand the concern that the 2 second delay is an issue, but if I only toggle into fullscreen once at the start of the day, I don't mind waiting 2 seconds and would rather that than lose the option to do it altogether.

[bpasero]

When I tested it the delay was easily >5s. I would like to wait for a proper fix.

[voxpelli]

@bpasero You mentioned that @deepak1556 had a fix for this? Where can one follow the progress on that fix getting released and possibly implemented here?

[bpasero]

With Electron update, this seems to work fine again. I enabled this setting again.

[isidorn]

Works great with latest electron, thanks a lot.