Vscode: Why is there no Chinese after the update?

[Yurunsoft]

• VSCode Version: Code 1.13.0 (376c52b955428d205459bea6619fc161fc8faacf, 2017-06-08T16:43:13.058Z)
• OS Version: Windows_NT ia32 10.0.14393
• Extensions:

|Extension|Author|Version|
|---|---|---|
|php-intellisense|felixfbecker|1.3.0|
|crane|HvyIndustries|0.3.6|
|phpcomments|Yurun|0.0.1|;

---

[Yurunsoft]

可能是这次更新的问题，我找到解决方法了
https://code.visualstudio.com/docs/getstarted/locales

[cyea]

更新后我也有这种问题 也是这种办法解决了

[popcorner]

But it should be in Chinese automatically.

[zce]

@popcorner
+1

[bestvow]

@popcorner
+1

[Yurunsoft]

@popcorner +10086

[rebornix]

@Yurunsoft @bestvow @chenyeah 请问你们之前是否有修改过 locale.json？另外你们的系统语言是中文吗？更新之前 VS Code 显示为中文，但是更新之后就变成英文了？

[Yurunsoft]

@rebornix 没修改过，系统语言是中文

[abc45628]

以前安装好之后就直接是中文了，所以没动过locale.json，但是这次更新之后就直接变英文了

[rebornix]

Summary of this issue:

• On both macOS and Windows, after updating to latest version of stable, the display language falls to English even if the system display language is others (at least Chinese).
• If users have opened/edited locale.json, then they don't run into this issue.

I tested electron.app.getLocale() on my Windows and it return an empty string, our locale detection fails. cc @bpasero @dbaeumer

[bpasero]

I would be surprised if this was an Electron issue simply because we did not update Electron during this milestone.

@rebornix Does it make a difference to start from Dock vs Terminal?

[rebornix]

@bpasero whether launching from dock or terminal, it displays English always.

[dbaeumer]

@bpasero I did some further testing and electron.app.getLocale() returns an empty string even when running under an English locale. So something did change in Electron. I will check if this happened in 1.12 already.

[dbaeumer]

This was caused by us not wating for app ready anymore when loading the loader. The call app.getLocale() only returns a valid result after the app is ready.

To workaround this problem for now do the following:

• either start code from a terminal and pass the locale using the --locale switch. E.g. code --locale=de to switch to a German UI
• Configure the local using F1 > Configure Locale command.

[jrieken]

The bad change is https://github.com/Microsoft/vscode/commit/174fafae53ec26bc3dc1216080061449b17fb080

[jrieken]

Pushed a revert commit https://github.com/Microsoft/vscode/commit/5194bbbe8e1793fdd407c8d7da93d6d6cda88f19 to make us wait again for the appReady-event and only then ask for the locale

[jens1o]

Will/How much this affect(s) the startup performance?

[dbaeumer]

Verified on source that we know get the right app locale again.

[zmyjs]

me too!

[sharp-summit]

System.Console.WriteLine("me too!");

[jrieken]

Adding verified-label based on the last three comments

[AxisRay]

上次更新后已经习惯英文界面了，突然换回来还有点不适应……捂脸

[Chanzhaoyu]

中国人自带简繁转换，程序猿工具自带中英转换