Vscode-vsce: Error: SVGs cannot be used as icons

[felixfbecker]

Just wanted to a release a new version of PHP IntelliSense, but the build broke:
https://travis-ci.org/felixfbecker/vscode-php-intellisense/builds/247593000#L917

I have been using an SVG as an icon forever and that has always worked fine:
https://marketplace.visualstudio.com/items?itemName=felixfbecker.php-intellisense

[LaurentTreguier]

I am experiencing that issue as well. The message looks like it's intentional though (Error: SVGs are restricted in README.md; please use other file image formats, such as PNG)... But forbidding SVG's while they didn't pose any problem before seems like a weird decision to me.

[felixfbecker]

yeah, especially since

• this was not a major release
• SVGs are just objectively better than PNGs

[LaurentTreguier]

So this commit is responsible, somebody asked why and got no answer =/
Only trusted sources are allowed now apparently

[joaomoreno]

The same answer from #181:

Changes are indeed coming about SVG support in the Marketplace. More information in the upcoming release notes: https://github.com/Microsoft/vscode-docs/blob/vnext/release-notes/v1_14.md#changes-for-extension-authors

It's a sad restriction but a necessary one.

[felixfbecker]

Instead of throwing an error, how about silently converting the SVG to a PNG with https://www.npmjs.com/package/svg-to-png?

[luanpotter]

Hey... github actions generates a svg badge and there is no way to get a PNG badge:
https://github.community/t/png-image-for-actions-badge/18178
In fact, there is one in this repo's readme! (which of course is not a vscode plugin)

Can't we support at least badges as svgs, or convert, or just ignore them instead of the error (I don't care a lot for a build sucess badge on the store page but I do care about it on my project repo)?

Otherwise I can't see how to cleanly interop github actions and vscode...

[ipatalas]

@luanpotter same here. This is still not fixed. I can't add GH Actions badge because it's SVG :/

[joaomoreno]

The VS Marketplace now has an open issue tracker, feel free to submit this feature request over there: https://github.com/microsoft/vsmarketplace