Vscode-vsce: Revert changes ignore file semantic

[joaomoreno]

In https://github.com/microsoft/vscode-vsce/pull/418 we fixed https://github.com/microsoft/vscode-vsce/issues/417 by adopting npm's ignore module for our .vscodeignore semantics. This actually broke a lot of extensions:

• https://github.com/microsoft/vscode-vsce/issues/576
• https://github.com/microsoft/vscode-vsce/issues/583
• https://github.com/microsoft/vscode-vsce/issues/584
• https://github.com/microsoft/vscode-vsce/issues/585
• https://github.com/microsoft/vscode-vsce/issues/587

Semantic differences

It used to be possible to write such a rule:

node_modules
!node_modules/highlight.js/styles

With npm's ignore module, we're force to do this instead:

node_modules/*
!node_modules/highlight.js
node_modules/highlight.js/*
!node_modules/highlight.js/styles

Plan

Apart from being a breaking change, I argue this is a change in behavior for the worse. For those two reasons, I propose to simply revert the change for 1.95.0.

• [x] Revert change
• [x] Write test cases which lock us in our semantics for future changes
• [ ] Create PRs to revert the damage done

Sorry

Finally, thanks all for the patience and the persistence in filling issues. I apologise for my stubborness. We should've caught this early on and optimized for compatibility. 🙇‍♂️

cc @aeschli @Pustur @fyangstudio @larshp @kitsonk @Timmmm @juli1 @orph @GordonSmith @ntotten @PeterWone

[GordonSmith]

@joaomoreno any thoughts on simply supporting the "files" section in package.json to specify which files should go into the vsix?

[joaomoreno]

No thoughts.

[larshp]

note this change was published in 1.95.0

[Timmmm]

@joaomoreno any thoughts on simply supporting the "files" section in package.json to specify which files should go into the vsix?

I agree that would be more intuitive. Definitely feels weird for everything to be published by default!