Vscode-r: remove or warn about cmd + 1 shortcut defaults

[maxheld83]

These shortcuts (defaulting to CMD on macOS, but same problem otherwise)

Run nrow, length, head, thead, names functions (Ctrl + 1, 2, 3, 4, 5)

overwrite the vscode defaults used to navigate between different editor groups:

Focus into 1st, 2nd or 3rd editor group

(from here).

This can fixed by the user by removing these shortcuts, but it takes a while to figure out.

I also think the group navigation is a fairly basic shortcut in vscode that may not be worth touching.

Thanks for the amazing work!

[andycraig]

Hi @maxheld83, thank you for this suggestion.

@Ikuyadeu @renkun-ken I agree that it would be better not to override these default VS Code shortcuts. I think we should remove the shortcuts for these commands.

[renkun-ken]

@andycraig I agree. In fact, I revert all these in my key bindings from the beginning.

[keita-makino]

@andycraig The wiki page is not fixed yet, FYI.

[andycraig]

Hi @keita-makino, here's the section of the Wiki that was updated: https://github.com/Ikuyadeu/vscode-R/wiki/Keyboard-shortcuts#removed-keyboard-shortcuts

If there's anything specific that seems to be missing/needs fixing, let me know.

[keita-makino]

@andycraig I see, but I meant the one on the top page. This description seemed to tell that the binding is by default.

(I sent the comment from my personal account one once by mistake so you'd get two notifications... sorry for that)

[andycraig]

@keita-makino Oh, the README! You are right, I missed that. Thank you! I'll fix it this weekend. A PR would of course be welcome too.

[keita-makino]

@andycraig No it's the top page of the wiki, so I cannot make a PR... Thank you for your cooperation though.

[andycraig]

@keita-makino Thanks for persisting, I understand now. It's the bit of the Wiki that has a copy of the README. I will fix.