Vscode-python: Opening a notebook for the first time shows Python core notifications that don't apply to notebooks

Created on 14 Aug 2020  Â·  5Comments  Â·  Source: microsoft/vscode-python

Environment data

  • VS Code version: 1.48.0-insider
  • Extension version (available under the Extensions sidebar): v2020.8.101144
  • OS and version: macOS 10.15.6 (19G73)
  • Python version (& distribution if applicable, e.g. Anaconda): Python 2.7.17 64-bit
  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...): conda
  • Relevant/affected Python packages and their versions: N/A
  • Relevant/affected Python-related VS Code extensions and their versions: N/A
  • Value of the python.languageServer setting: Jedi

Expected behaviour

I get that I need to have some things appear for things to work, but we should do it in a graceful way.

Actual behaviour

Multiple notifications appear at the same time:

  1. Trusting notebook (can be deferred until you try to run a notebook)
  2. Survey (should be deferred until a later time)
  3. Conda env for integrated terminal (should be deferred until user opens terminal)
  4. Tip for python interpreter (can either be deferred until later or surfaced in the welcome page)

Steps to reproduce:

  1. Install Python extension for the first time (fresh user data directory)
  2. Open a .ipynb file
  3. :bug: a large amount of notifications appear

image

type-bug

All 5 comments

Thanks for the issue @misolori. The survey should stop appearing if you click 'No, thanks'. And if you only use secure sources or create your own notebooks you can remove the trust notification with the setting 'Python › Data Science: Always Trust Notebooks'.

We'll discuss the issue in an upcoming meeting, but let me know if that is good enough.

I understand that there are ways to dismiss some of those notifications, my point was that there is a lot of noise on your first experience. It’s like being greeted by 4 people telling you 4 different things at the same time.

For example: why not show the survey after some time? Why not show the trust notebook notification when you attempt to run a cell? Delaying these will significantly improve the experience.

Definitely agree on the survey. And the trust notebook is a good idea, I'll make sure to go over it on the meeting.

Thanks for the feedback! Few things. First, a user will not receive the survey on first opening of a notebook. Second, we must show the Trust popup. We can't wait for the user to press Run because the user may just want to see the outputs. The third and fourth problems are in the core Python code. So I'm going to tag this for them to see.

Duplicate of #7700

Was this page helpful?
0 / 5 - 0 ratings