Vscode-pull-request-github: Can't exit review mode
- Extension version: 0.5.0
- VSCode Version: 1.32.1
- OS: macOS 10.14.3
Steps to Reproduce:
- Click "Exit Review Mode" in a PR description.
- You will need to choose the relevant repo in a multi-folder workspace (Separate issue https://github.com/Microsoft/vscode-pull-request-github/issues/654)
- Choose a different branch.
- The pull request remains in the status bar and still has a check mark in the pull requests view, if you switch back to the branch you will still be in review mode.
It makes sense for the pull request to be "deselected", that is, for it to disappear from the status bar and the check mark removed from the pull requests view. The same state you start in before you enter review mode. Might even make sense for this to not require switching a branch. Just "exit review mode" so you are back to the same state as checking out the branch normally.
segevfiner
All 2 comments
+1
MartinSmeyer
on 19 Aug 2019
There are multiple duplicates of this issue already. I for one am not using this extension due to this (Though I have a feeling I will also encounter other issues...), and have seen others having to constantly disable/enable it or other workarounds when they do use it in situations where they would like to exit review mode and disable its UI without switching branch or when going back to a branch that was in review mode before.
segevfiner
on 16 Jul 2020
Related issues
RamonMeffert
路
3Comments
radu-matei
路
3Comments
Tyriar
路
3Comments
sbatten
路
4Comments
scrossan-crown
路
4Comments
Most helpful comment
There are multiple duplicates of this issue already. I for one am not using this extension due to this (Though I have a feeling I will also encounter other issues...), and have seen others having to constantly disable/enable it or other workarounds when they do use it in situations where they would like to exit review mode and disable its UI without switching branch or when going back to a branch that was in review mode before.