Vscode-pull-request-github: Go to definition would be usefull

[scrossan-crown]

I think that being able to go to definition (if in different file ask user if they want to open changes or file) or at least peak definition. I find myself opening up the original often file and using go to definition.
Also I'm not sure if this is the right place to ask for this but if the changes view could keep it's scroll position when swapping to another file, that would be really handy.

[danvk]

In general it seems like all the intellisense features are disabled for diff views. I assume this is intentional but I'd love to see this added. In my mind this is the main win of doing code reviews in your editor.

[scrossan-crown]

I agree, I noticed that the diff window is read only and that could be the reason you don't get any intellisense features. One thing I've found that's good about that is you can do some changes check if they work then go to the diff view and suggest them and the diff view shows the unchanged code.

[markfields]

As a short-term concession, how about a shortcut to open the original file for the current diffed file?

[markfields]

One thing I've found that's good about that is you can do some changes check if they work then go to the diff view and suggest them and the diff view shows the unchanged code.

I would hope that even having intellisense etc wired up for the diffs, it would be siloed from the current state of the branch locally. There is some interesting thinking to be done down that path though vis a vis GitHub's new "suggestions" feature...