Vscode-pull-request-github: Support the new code review suggestions
Github announced a new suggestion api that started being added to the code review tools.
Right now the extension takes these at face value as text.
For example take this comment.
In github:
In vscode:
Maybe have the suggested changes be shown as a diff? maybe even have a prompt to incorporate the changes, similarly to a merge conflict.
Tadaboody
All 8 comments
This would be really useful to have it when making reviews through the VS code.
glemaitre
on 28 Jan 2019
With 589 and this functionality you would be pretty much be able to do the whole PR from VS code!
mledom
on 30 Jan 2019
Does this FR only cover displaying the suggestions made elsewhere or also being able to make suggestions from VS code? Both would be great!
melink14
on 14 Sep 2019
I found this feature very interesting.... is it gonna be put in the roadmap ?
jonathanvila
on 17 Apr 2020
It would be very handy if I could just open a file, make some changes in it and post them as a suggestion.
arubtsov
on 21 Apr 2020
It would be really big improvements for dev productivity
Draal
on 27 Aug 2020
Any update on this? Currently the suggestion overflow the width of the comment box without anyway to scroll
ankitbko
on 12 Apr 2021
Yes, this feature would be very useful. Currently we can add suggestions (using ```suggestion) but they don't show up properly. For example, the suggestion to remove a line does is not displayed at all.
sahmadi-wave
on 16 Apr 2021
Related issues
erihanse
路
4Comments
octogonz
路
3Comments
jrieken
路
3Comments
sbatten
路
4Comments
kieferrm
路
4Comments
Most helpful comment
Does this FR only cover displaying the suggestions made elsewhere or also being able to make suggestions from VS code? Both would be great!