Vscode-pull-request-github: Description node in "Changes in Pull Request" should use the PR title

[eamodio]

The root node of the "Changes in Pull Request" tree is "Description", which imo isn't very helpful. It should use the PR title.

[justinliew]

Is this a dupe of https://github.com/Microsoft/vscode-pull-request-github/issues/480?

[RMacfarlane]

@justinliew I think this is a slightly different request - #480 is for the node within the "GitHub Pull Requests" tree that's always visible when you're in a GitHub repo, and this is for the "Changes in Pull Request" tree that shows up when you check out a PR. But certainly would be similar changes

[eamodio]

No this is in a different tree -- in #480 the root node already has the PR title, so the Description node would be strange to repeat it. But in the other tree, the Description node has no parent node with the PR title.

[justinliew]

Ah, thanks for the clarification, folks!

[shatgupt]

I am planning to work on this. Any pointers?

[RMacfarlane]

Thanks @shatgupt! The code that sets this title is here: https://github.com/Microsoft/vscode-pull-request-github/blob/778be8188cbfb8e65300d7571b60eeaca700509c/src/view/prChangesTreeDataProvider.ts#L64

[shatgupt]

Created a PR for this: https://github.com/Microsoft/vscode-pull-request-github/pull/528
Looks like this now: