Vscode-pull-request-github: SCM: change icon hides when extension is installed

[bpasero]

I have no clue why but with this extension installed, icons for change type are removed from my SCM view shortly after window load:

/cc @joaomoreno

[joaomoreno]

cc @jrieken

[jrieken]

hm, interesting...

[jrieken]

Not able to reproduce this with 0.1.2

[RMacfarlane]

I'm also not able to reproduce this with the latest version, 0.1.6, so will close this

[bpasero]

Still happens:

[jrieken]

Steps? Logs? Console logs?

[bpasero]

@jrieken

• yo code
• git commit -m "init"
• rm README.md
• Git > Changes View
• wait 2 seconds

=> :bug: icon is gone

[bpasero]

[bpasero]

logs.zip

[jrieken]

Problem seems to be decoration provider that return kinda empty objects... We then later fail to merge the git info onto it... @RMacfarlane try returning undefined here https://github.com/Microsoft/vscode-pull-request-github/blob/73f63b3ff9ee2b7258f2e17fe463a3d6e8ed7936/src/view/reviewManager.ts#L680 and https://github.com/Microsoft/vscode-pull-request-github/blob/6aad2ad237b65ff9c8b581ba4225b1fcbe820768/src/view/prsTreeDataProvider.ts#L94

[bpasero]

I am still seeing this all the time, was this pushed?

[RMacfarlane]

Hmm, yeah it was pushed. The change should be in version 0.2.0 of the extension

[bpasero]

Still happening:

After a window reload the issue seems gone, nothing in the console.

[RMacfarlane]

Closing as a duplicate of https://github.com/microsoft/vscode/issues/81467