Vscode-pull-request-github: Remove "Signed in" status bar item

[bpasero]

Follow up from https://github.com/Microsoft/vscode-pull-request-github/issues/274

The status bar item that shows that I am signed in to GH does not seem to have any purpose other than taking away space from the already crowded status bar. It should be removed in its current form.

Reasons to keep it (maybe, under discussion):

• clicking brings me to PR views
• clicking offers actions to quickly checkout to another PR or back to the branch where I left from

[ramya-rao-a]

Or it allows you to sign out. Which is what most "Sign in" buttons change to after signing in.

But I would prefer to have it removed.

[fabiospampinato]

IMO this statusbar item is totally useless.

Or it allows you to sign out.

I see no "Sign Out" command in the command palette, there should be one there. If somebody really wanted to trigger that command from the statusbar there are already extensions for adding custom buttons to the statusbar that trigger a command.

If you want to have this "feature" bundled with the extension at the very least there should be an option for disabling it.

Reasons to keep it (maybe, under discussion):

• clicking brings me to PR views
• clicking offers actions to quickly checkout to another PR or back to the branch where I left from

Maybe it could be useful in these scenarios, but I would definitely remove the username (who finds that useful?).

[fabiospampinato]

Also this statusbar item doesn't have any title set, maybe kind of useless informations such as the username can be written there instead.

As an unfortunate consequence without a title I can't write a proper selector for removing this thing via CSS 😩

[RMacfarlane]

How about adding a setting for displaying it?

I understand that it takes up space, which is especially bothersome since other extensions also add account information here, but IMO it is displaying a status and therefore belongs in the status bar. I'd also like to see it have functionality for switching accounts.

[RMacfarlane]

Talked about this some more in the UX call today - some other possible functionality would be to have this item navigate to the pull request view in SCM viewlet, or bring up a list of actions that changes contextually based on whether you are in review mode.

We also discussed removing the Pull Request # status bar item that appears in review mode. Since the branch information is already shown on the left, for branches that the extension creates, the name will already contain the PR number. Also, there are already other visual indicators for review mode and other ways to get to the description page. The item could be removed and the signed in item could pick up the action of opening the current PR description

[fabiospampinato]

but IMO it is displaying a status and therefore belongs in the status bar

@RMacfarlane should that status be displayed in the first place though? If all extensions that could display some kind of status to the statusbar did it the statusbar would become useless.

I obviously have no saying in this, but IMHO it should work like this:

1. A single icon to the statusbar
2. Username, PR id etc. into the tooltip
3. Clicking it opens up a quickpick containing all appropriate commands for switching account, signing out and what not (like Live Share is doing).

[ELLIOTTCABLE]

A way to configure this would be great, as there's currently no other way to remove this from the statusbar … and I have enough other (more important) things down there that it's crowding out my Vim-mode command line, which is … a real problem. /=

[JacksonKearl]

VS Code has allowed removing status bar items since the June 2019 release.

With #1410 clicking the status bar item item will give you options for changing queries, remotes, or signing out of GitHub.