Vscode-pull-request-github: Check out vs checkout

[Tyriar]

Right now "check out" is used throughout but I think we should be using "checkout" as that's the underlying git operation used and it's referred to as "the checkout operation" in the docs https://git-scm.com/docs/git-checkout

[auchenberg]

Agreed. It would expect Checkout PR

[rebornix]

Interesting, https://github.com/Microsoft/vscode-pull-request-github/issues/177 . checkout is used when we are referring to the operation/command while we use Check Out as a verb.

cc @shana

[auchenberg]

Could we name the button Checkout Pull Request or Checkout PR to it use a "command" and not a verb?

[Tyriar]

From https://github.com/Microsoft/vscode-pull-request-github/issues/177#issuecomment-412611563

So on GitHub we use "check out" as a verb, and only use "checkout" when talking about the command or if talking about a specific feature with that name (like if we named a feature "the checkout button"). I don't know if the VS docs team has different guidelines for that usage tbh.

@shana where on GH is "check out" used? This is all I could find:

GH desktop, https://desktop.github.com/:

https://help.github.com/articles/checking-out-pull-requests-locally/

[auchenberg]

We have decided to use "checkout". Fixed in https://github.com/Microsoft/vscode-pull-request-github/commit/fc5e2ce048698d26d6aa28d93f0f90bdb460c6b9 + https://github.com/Microsoft/vscode-pull-request-github/commit/79e19a1e598fbc5680351c2a618b85617267961f

[roblourens]

Noooooo

"the checkout operation"

"Checkout" is an adjective, "The check out operation" is wrong. That's a different case from "Check out this PR"

TBH I think those usages in github are either wrong or references to the command itself. Note that they say "Checking out" and not "Checkouting". The git docs use "Check out" except referring to the command or in the above usage.

[auchenberg]

@roblourens What's the specific concern and proposal? We have updated the wording, so it looks like:

[Tyriar]

The screenshots look right to me.

[roblourens]

My proposal is still to use "Check out" instead of "Checkout"

[auchenberg]

Let's have a vote:Checkout vs check out vote with reactions. Closing today day 5pm PST.

👍Checkout
👎Check out