Vscode-material-icon-theme: [Icon Request] MJML file and folder

[jimblue]

Hi there,

Could you consider adding icons for mjml file and folder.

Here is a link to this awesome html email engine: https://mjml.io/ !

Cheers

[PKief]

Hi @jimblue, could you please add a list of file names / extensions and folder names for which you want to have a new icon?

[jimblue]

For sure, it's pretty easy:

file extensions .mjml
folder name: mjml

Sounds good?

[jimblue]

vs-code-icon extension have already done it, maybe it can help:

https://github.com/vscode-icons/vscode-icons/search?q=mjml&unscoped_q=mjml

[PKief]

Just checked it, we already have a file icon for files with the file extension *.mjml.

Related pull request: https://github.com/PKief/vscode-material-icon-theme/pull/200.

[jimblue]

@PKief wow, you really fast to answer, that's cool! ⚡️

ya indeed, it's working for file icon :) !
can we only go for folder icon then?

[PKief]

Hi @jimblue, the icon is not very suitable to be used as a folder icon, i.e. it does not fit very well on a folder as a motive. In addition, the folder name is not so widely-used, so we will leave it at the file icon here. But thanks for asking!

[jimblue]

Hello @PKief,

I'm coming back after a year to see if you can change your mind ?

Do you think we can reconsider this please 😄 ?

[PKief]

haha okay, will take a look at it tomorrow 🙂

[jimblue]

Haha awesome 🎉 🎉 🎉
Let me know if I can help 😄

[PKief]

Just created some folder icons for mjml:

Closed	Expanded

[jimblue]

Wow looks good, awesome job !
This was the last src folder missing an icon... You really made my day, thank you so much !

[jimblue]

Can't wait for future release now haha 😄

[PKief]

Thank you for the nice feedback! Yeah, next release will be available very soon 👍