Vscode-material-icon-theme: Annoying restart notification

Created on 18 Mar 2018  路  8Comments  路  Source: PKief/vscode-material-icon-theme


Is this notification supposed to be shown every time after the extension is updated and vscode already restarted?
Is there a real need for second restart? Is there anyone who really bother about this?
How can I disable this notification?

I have already set

    "material-icon-theme.showWelcomeMessage": false,
    "material-icon-theme.showUpdateMessage": false,

in my config.

Most helpful comment

@KillyMXI Yes, this is already implemented. If no changes to the icons are required, then the extension will not prompt you to reload the window.

All 8 comments

I know, it's very annoying if the notification is shown after every update. The reason for this is that the extension is downloaded with the default settings. If you have some individual settings for the extension in your user settings (e.g. different color of the icons), the extension recognizes the changes in your user settings and processes them. To enable the changes, the extension asks you to reload the editor. Otherwise the changes on the icons will not be visible until the next restart.

Because this is a common issue in other icon themes, an issue was created at the VS Code repository with the request to update icons immediately without restarting the whole editor.

If this issue will not be solved by the VS Code team in the near future I'll set an option to disable the restart prompt.

@PKief I was about to create the same issue, why is this being presented if I do not have individual settings?

screen shot 2018-03-19 at 6 25 35 am

Also do you expect high engagement on the changelog for an icons extension? Not sure presenting the changelog so prominently is a good UX.

@Tyriar Unfortunately the extension also watched the changes of the following settings:

"material-icon-theme.showUpdateMessage": false
"material-icon-theme.showWelcomeMessage": false

If they were set, no matter what value, then a restart was triggered.
I fixed it with https://github.com/PKief/vscode-material-icon-theme/commit/50e40e8e9ae8e219165e0ffb5445e4677109bae8#diff-c4136142413ab48def269bebf1c02f49R36.


I'm not sure about the changelog notification either. It has been part of my extension from the very beginning and nobody has complained about it since. But that doesn't mean that it is a good UX. Maybe I'll remove it in the future and probably nobody will miss it 馃槈

@PKief thanks, yeah I had showWelcomeMessage set.

On the changelog, inside VS Code we try to use notifications very sparingly as they interrupt users so it needs to be important 馃槂

With the next update the configuration material-icon-theme.showUpdateMessage will be set to false by default. So there's no notification anymore that asks the user if he wants to read the changelog. If desired, the option can be set to true.

Additionally you can now completely disable the restart message with the following configuration:

"material-icon-theme.showReloadMessage": false

From my side I would not recommend to disable the restart message because your icons may look different after an update (because of the default configurations). But anyways, if the notifications interrupt your workflow then you can now disable all notifications from my extension.

Thank you.
You could probably detect the default configuration though, where it is safe not to reload and no need for the message.

@KillyMXI Yes, this is already implemented. If no changes to the icons are required, then the extension will not prompt you to reload the window.

Thanks @PKief 馃憤

Was this page helpful?
0 / 5 - 0 ratings

Related issues

JonJamesDesign picture JonJamesDesign  路  3Comments

anxorl picture anxorl  路  3Comments

alchermd picture alchermd  路  5Comments

SMotaal picture SMotaal  路  4Comments

gencer picture gencer  路  3Comments