Vscode-material-icon-theme: Add assembly icon

[wopian]

vscode-icons uses this for their icon

I'd suggest something similar to the XML logo with 01/10. Colour of icon would be brown (#795548)

Extensions

• [.asm, .a51, .inc, .nasm] Assembly
• [.s, .ms] Unix Assembly
• '.agc' Apollo Guidance Computer

[PKief]

I've added the icon and updated the file extensions:

See icon here...

I tried many fonts and font sizes for the "0" and "1" to make it readable and I think this is currently the best solution. I hope you'll enjoy it, I will update the extension on the marketplace soon. Thank you for your PR and this feature request.

[wopian]

Would it not be more readable if the text was white?

[PKief]

The text is currently transparent and its color depends on the background color. You can see this if you change the color theme of your vscode (File -> Preferences -> Color Theme).

Here you can compare the icons in the default zoom mode:

White color theme:

Dark color theme:

As far as I can see, the icon with white text is not much better readable than the dark one. I also checked the icon of "VSCode icons", and it is not very readable, too ;) It is really hard to make it readable because of small icon sizes in the default zoom mode.

[wopian]

@PKief been thinking about these for a while, with seeing if it would be possible to get the icon to look closer to most icons in this theme.

I've seen it in several places with just 'ASM' or with a gear icon - which is already taken and doesn't have any resemblance to the language. Barely any icon themes on VS/Atom/Sublime have an icon for assembly and those that did used 0110 in some way.

There's 2 I feel could work:

• Ditch the file icon and have 0110 in Brown 400 or 300 and a thinner weight, e.g this.
• Use a microprocessor similar to this.

[PKief]

I tried it with a dark orange color (#FF6E40):

and a brighter brown (300, #A1887F):

What do you think is the best?

[wopian]

Orange looks far better 👍

The []'s used in that icon are probably too thick though. Same thickness as the {}'s in the YAML/JSON icons could be perfect 🤔

Edit: And uh, the bottom 0 isn't visually aligned in the materialdesignsicon.com icon - didn't notice it at first, now I see it every time I look at it 😨. Would it be possible to move it further to the right? 🙏

[PKief]

So now I changed it to this:

I think it looks great 😄

You can see the 1 and 0 very good and the orange color fits perfectly to the other icons.

Do you think this is ok?
Link to icon