Vscode-icons: Icons are not shown properly in tree, but in Open Editors are OK

[rbukovansky]

• [x] I'm using Visual Studio Code Version [1.5.0] [Insider]
• [x] I'm using the extension version [1.8.1]
• [x] I've regarded to the FAQ and they did not help.
• [x] My system is: Win7/64, Ubuntu/MATE 16.04.01 LTS
• [x] I'm sure this issue is not a _duplicate_?

Description:
After today's update to newest VS Code Insiders and latest vscode-icons, I'm getting icons shown correctly for Open editors, but for Tree view I'm getting placeholders instead of file icons.
Folder icons are just fine.

This is happening on both listed machines.

Steps to reproduce:

1. Update VS Code Insiders
2. Update vscode-icons
3. Re-enable vscode-icons

_Expected behaviour:_
Correct file icons are shown in tree view.

_Actual behaviour:_
Placeholder/generic file icon is shown in tree view.

[wclr]

Yes the same. Not sure if can rollback insiders. https://github.com/Microsoft/vscode/issues/11084

[robertohuertasm]

@rbukovansky @whitecolor thanks for the heads up! It seems something changed with the latest version. As I was going to roll out 1.8.2 today I'll try to fix it. Hopefully, Insiders breaks will tend to diminish once the new VSCode official icons API gets stable and our extension integrates with it.

[rbukovansky]

Sounds good to me... Thanks.

BTW It would be much easier if MS decided to integrate/merge your code to VS Code. That would save a lot of time for everybody...

[robertohuertasm]

Fixed in 6e7b1ca40b7946c61f101d26a6c977cf66724d98
I will release 1.8.2 in a minute

[robertohuertasm]

Already published, you should be able to download the new version now. Let me know if this is not still happening! :wink:

[rbukovansky]

Looks good! Thanks.

[wclr]

Heh, after long iteration cycle with update/enable/uninstall/... it finally worked, thanks)

[robertohuertasm]

@rbukovansky @whitecolor good to now the fix is working! :grinning:

[wclr]

Oh it happened again after today update, and I'm not able to restore it yet with unstall/install/enable/disable.. (

[robertohuertasm]

If they've changed again their code that won't be fixed by executing the commands. I will take a look asap and let you know.

[wclr]

Ok, just after your yesterday fix it too didn't work at once, so have to do some actions.

[robertohuertasm]

@whitecolor 1.8.4 is out! It should be fixed by upgrading the extension.

[wclr]

@robertohuertasm :+1: thanks it works

[wclr]

@robertohuertasm though icons on files seems ok icons on folder doesn't appear, what can be the problem?

I won't update insiders any more :sob:

[robertohuertasm]

@whitecolor you mean custom folders?

[wclr]

@robertohuertasm
node_modules, test, src, etc I believe it is custom, simple folder icon is shown on all folders

[wclr]

@robertohuertasm btw is it possible to support custom icons folders in a particular project? say if icon pictures will be place some where nearby.

[robertohuertasm]

1.8.5 is out with a patch.
@whitecolor I'm not really sure to follow you but if you want to add custom folders with your own icons is not so easy. The only thing you could do is use a current icon, substitute it with another and then using associations change the normal behaviour.

[wclr]

@robertohuertasm it works, thanks ok I will create an issue for this.

[rbukovansky]

@robertohuertasm Installed the last VSCode Insiders:

Version 1.6.0-insider
Commit d81ee41c51cae93a5cac967e42a28660a3a7e005
Date 2016-09-23T05:58:22.484Z
Shell 1.3.5
Renderer 52.0.2743.82
Node 6.3.0

and we are broken again in Explorer window...

Please take a look.

[wclr]

@rbukovansky do you use build-in icon themes?