Vscode-gitlens: Disable click action on recent change

Created on 30 Mar 2020  ยท  10Comments  ยท  Source: eamodio/vscode-gitlens

I like seeing the recent change / author annotations on blocks:

image

However, I keep finding myself accidentally clicking them, which shifts the entire editor to the right. I'd like to keep the annotations, but disable the click action (or make it harder to accidentally trigger). Is there an option for this?

good-first-issue help-wanted feature

Most helpful comment

@abdusabri Looks great! Awesome work!

All 10 comments

While you can control what happens when you click on it, you can't currently have it do nothing. That is a good idea.

I've an early stage working prototype ๐Ÿ™‚

This is how it looks when both Authors and Recent Changes commands are disabled
both-disabled

This is how it looks when only the Authors command is enabled
authors-enabled

This is how it looks when only the Recent Changes command is enabled
recent-change-enabled-2

The approach I'm thinking about would involve adding 2 config entries as shown below, and would make them both enabled by default
config

Would that be a good approach to implement this feature?

Awesome! Thanks so much for tackling this! Instead of adding a new enableCommand flag, I would suggest just adding false to the command, so it would be command: CodeLensCommand | false. That would make the changes required (especially in the GitLens Settings UI) less.

Thanks @eamodio for the feedback! Will proceed accordingly.

Based on that, the Settings UI should be like this, correct?
settings-ui

Yeah, I like that UI (I honestly was thinking about just a _When clicked_ does nothing type action in the dropdown -- but I like yours much better). The might be a challenge with it being a combine setting with that UI - since unchecking it would set it to false which will affect the dropdown. I'm not in front of a machine atm but it might be fine ๐Ÿ˜„

Awesome! Thanks for the feedback!

I got inspiration from the existing views.repositories.showBranchComparison setting. Based on my testing, it seems to be working as expected ๐Ÿ˜„

Here is a screen capture for a fully functional implementation ๐Ÿ™‚
full-flow-4

Here is how it responds to parent settings being disabled or enabled
parent-settings

@abdusabri Looks great! Awesome work!

I'm very sorry about the wrong references to this issue ๐Ÿ˜”, was testing some changes on my fork while working on another issue and didn't realize I had used the wrong issue number ๐Ÿคฆโ€โ™‚๏ธ. Please ignore

Added in GitLens 11

Was this page helpful?
0 / 5 - 0 ratings

Related issues

dwlsalmeida picture dwlsalmeida  ยท  3Comments

batjko picture batjko  ยท  4Comments

vgrafe picture vgrafe  ยท  3Comments

rfgamaral picture rfgamaral  ยท  3Comments

obrejla picture obrejla  ยท  3Comments