Vscode-git-graph: Keep track of last opened file in commit's listed files

Created on 4 Jul 2019  路  4Comments  路  Source: mhutchie/vscode-git-graph

Describe the feature that you'd like
When viewing a commit's changed files, clicking on a file opens the diff editor. Would it be possible to change the appearence of the file I clicked onto, so that it keeps track of the the last opened file from the list. This is especially useful for commit review.

Additional context (optional)
The commit's changed files list:
image

feature request

Most helpful comment

Thanks for making this suggestion, this would be awesome to have in Git Graph!

As you suggested, having an indicator of the last opened file from the tree would be really useful for commit reviews! Perhaps this could be extended one step further, so it would indicate all files that have been opened from the tree - this would mean that the user can review the files in any order, and have confidence they have reviewed each file (similar to the BitBucket PR / Code Review process works). What are your thoughts on this?

All 4 comments

Thanks for making this suggestion, this would be awesome to have in Git Graph!

As you suggested, having an indicator of the last opened file from the tree would be really useful for commit reviews! Perhaps this could be extended one step further, so it would indicate all files that have been opened from the tree - this would mean that the user can review the files in any order, and have confidence they have reviewed each file (similar to the BitBucket PR / Code Review process works). What are your thoughts on this?

I like your extended proposal as it would be really helpful. I just admit that the appearence of the visual clue is out of my head right now :-p, but if you were to make some design proposals we could comment them if you desire.

One option is to dim the names of viewed files :

1


Another option is to put an "Unread" mark next to file names and remove it once a file is viewed :

2

Personally, I prefer the latter.

I've implemented both:

  • Code Reviews - Keep track of which files you have reviewed in the Commit Details & Comparison View.
  • Last File Viewed Indicator - Indicates which file was last viewed (doesn't need to part of a Code Review).

These will both be available in v1.14.0, which will be released in the next day.

Was this page helpful?
0 / 5 - 0 ratings