Vscode-git-graph: Show reflog

Created on 29 May 2019  路  9Comments  路  Source: mhutchie/vscode-git-graph

Describe the feature that you'd like
Add an option to display reflog commits, like when running git log --reflog

Additional context (optional)
Ideally this would be a checkbox in the UI or something, rather than a setting, as it's the sort of thing you'd turn on temporarily rather than all of the time. It would also be nice if they're visually distinct from normal commits, maybe greyed out?

feature request nice to have

Most helpful comment

This will be available in v1.23.0.

If you'd like to use it before the next release, you can download v1.23.0-beta.2, and install it following the "Manual Installation" instructions provided here.

All 9 comments

Thanks for this suggestion! This functionality would definitely be great to have in Git Graph. I completely agree with your thoughts on how it should be incorporated!

This issue has been left open for 7 months for others to express interest in this feature. As only one other Git Graph user has indicated they would like this functionality in this period, it indicates to me that this feature would be used by very few users.

Although this functionality would definitely be nice to have, and be useful under certain circumstances, the lack of user interest is indicating that it will deliver little overall value for the current Git Graph user community. Because of this, and that it is significantly complicated to appropriately integrate in the UI, I can't justify the time required to implement it at the present time. I'll close this feature request for now and move it to the backlog.

Note to other users reading this in the future: If you'd like this functionality, please reply to this thread to express your interest. I'd happily re-open and add this feature if there was any indication it would be used by a decent number of users.

I frequently run into situations where I would like to have this feature. If I accidentally make a commit off a branch then switch branches, the new commit disappears. It seems I can only fix this situation from a terminal.

I recently took another look at this, as it's still a feature which I think would be incredibly valuable. When I first tried to hack it in myself last year, I quickly discovered that it wasn't something the back-end would support as you pointed out @mhutchie .

However, doing a little experiment just now, I've found that due to the various back-end improvements that have made to the graph since, reflog works perfectly just by adding '--reflog' into the args variable of DataSource::getLogs()! Enabling the feature properly would just be a matter of hooking up UI to enable that.

I'd offer to create a pull request to add it in myself, but I doubt I'll have the spare time any time soon. But I'd be very grateful if someone else manages to do that, or if @mhutchie can find the time to fit it in.

In fact, I've created a patch to enable reflog. I'm not used to the github workflow, so if someone else wants to create a PR with that code, it'll probably get stuff happening faster than waiting for me to figure out how to do that.

Thanks @t-gehring! I鈥檒l have a look at your patch after the next release is out (hopefully this weekend), as the release will already be very large with loads of new features.

I'm re-opening this feature request, and intend to include it in the next available release of Git Graph, as:

  • There has been an increased rate of user interest for it.
  • I've read up & learnt more about the reflog, and there doesn't appear to be any undesirable side-effects of including --reflog in the git log command (which is used get the commits for the Git Graph View).

    • Since this feature request was first raised, other improvements to Git Graph have resolved all of the issues I found when first investigating the feasibility of this feature request last year.

  • @t-gehring has kindly provided a working proof of concept (which I've had a look at, and tried out now that Git Graph 1.22.0 was released last weekend).

This will be available in v1.23.0.

If you'd like to use it before the next release, you can download v1.23.0-beta.2, and install it following the "Manual Installation" instructions provided here.

I've downloaded the latest beta to check this out, seems to be working perfectly. Fwiw I think that where you've put it in the UI is a lot better than in my proof of concept. Thank you so much for including this!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ntziolis picture ntziolis  路  7Comments

bboehmke picture bboehmke  路  6Comments

arslivinski picture arslivinski  路  7Comments

kanlukasz picture kanlukasz  路  3Comments

morganlombard picture morganlombard  路  5Comments