Vscode-extension-for-zowe: Regression: Dataset search not working

[Colin-Stone]

On the current master the Dataset search favorite is returning a Cannot read property getSession of null

[jellypuno]

This is addressed in PR #353

[Colin-Stone]

Addition of the Optional credentials added a block of code that accesses a nodes session. This had not been populated on a dataset Session object and so when referenced was null.
Quick fix move the lines
const sesName = line.substring(1, line.lastIndexOf("]")).trim(); const zosmfProfile = Profiles.getInstance().loadNamedProfile(sesName); const session = zowe.ZosmfSession.createBasicZosmfSession(zosmfProfile.profile);
above the if (favoriteDataSetPattern.test(line)) {

and then reference further below
const node = new ZoweNode(line.substring(0, line.lastIndexOf("{")), vscode.TreeItemCollapsibleState.None, this.mFavoriteSession, session);

[Colin-Stone]

This is addressed in PR #353

But was this considered a GA item?.

[jellypuno]

This is addressed in PR #353

But was this considered a GA item?.

Yes. Issue #352 is part of 1.0 :). So PR #353 Fixes issue #352 and #356 ;)

[Colin-Stone]

Okay I thought #352 it was coming next release as per..
@jalel01 jalel01 added this to the 1.1 Release milestone 3 days ago

[jellypuno]

Okay I thought it was coming next release as per..
@jalel01 jalel01 added this to the 1.1 Release milestone 3 days ago

yeah. @crawr and I were able to finish it last friday so we told him we can add it in v1.0

[Colin-Stone]

Duplicate of #352