Vocabulary: Modified tab components [Feature request]

Created on 16 Jun 2020  路  7Comments  路  Source: creativecommons/vocabulary

Problem

I observed that tabs component used in the CC Search Extension Mockup have a different design.

I see two new flavours of the component :

Screenshot from 2020-06-16 18-21-01

Screenshot from 2020-06-16 18-14-11

Maybe more discussion is needed for the second one. Is it really a tab component or something else(a header?). It do functions like a tab in the Mockup.

Implementation

  • [ ] I would be interested in implementing this feature.
good first issue help wanted

Most helpful comment

@makkoncept please also see the length of the bottom border (aligns with the text, no extra left+right spacing, and various hover/active differences:

new
Screen Shot 2020-07-27 at 3 28 38 PM

existing
Screen Shot 2020-07-27 at 3 30 00 PM

All 7 comments

I need to add as a component the tab used in Browser extension. We have faced different levels of content navigation and that's why the component difference. Thanks for bringing this.

The Design Library is updated with the two navigation components.

@panchovm The 'Line Tab' should replace the existing tab style here: https://cc-vocabulary.netlify.app/?path=/story/layouts-tabs--tab, yes? Just want to confirm 馃樃

Yes @zackkrida. It should be replaced.

@zackkrida @panchovm I am working on this issue. The "line tab" in the design library looks very similar to the existing tab style except for the thicker bottom border. Am I missing something else?

@makkoncept please also see the length of the bottom border (aligns with the text, no extra left+right spacing, and various hover/active differences:

new
Screen Shot 2020-07-27 at 3 28 38 PM

existing
Screen Shot 2020-07-27 at 3 30 00 PM

As @zackkrida said, the extra left and right spacing are truly important. They give the alignment effect when is placed above/below paragraphs. Thank you both.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Dhruvi16 picture Dhruvi16  路  5Comments

zackkrida picture zackkrida  路  5Comments

zackkrida picture zackkrida  路  3Comments

nimishbongale picture nimishbongale  路  4Comments

nimishbongale picture nimishbongale  路  4Comments