Vocabulary: Discussion: Conditional required status checks

Created on 18 Sep 2020  路  3Comments  路  Source: creativecommons/vocabulary

Prior art

_Some existing discussions in this problem space:_

The problem

Within GitHub actions there is the concept of paths. Actions can be triggered to run _only_ when specific files match the specified paths. Unit tests and linting only run when changes have been made to a specific package (with paths like packages/[package-name]). This is much faster and efficient than running _all_ CI code even if that particular package hasn't had any edits.

What this means is that different PRs have different required status checks, and we _can't_ set blanket requirements for every PR.

Possible solutions

  1. Run all CI actions all the time, regardless of edited package, and use get-diff-action to skip the steps in a job when that package has not been edited. This is probably the best approach, but makes it _look_ like some jobs passed, when in reality they were skipped.
  2. Disable required status checks for vocabulary. PRs and deployment workflow are manual _anyway_, so this isn't the worst idea.
label work required discussion low dx

Most helpful comment

I vote for (1). Required status checks are a good check for maintainers to have and reduces human error.

All 3 comments

I vote for (1). Required status checks are a good check for maintainers to have and reduces human error.

Hi everyone, I have the same problem.
Is there a way to skip required checks if the paths was not met for those?

Hi @TomasVotruba there is still no great solution for this problem. Only hacks or compromises.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

obulat picture obulat  路  5Comments

zackkrida picture zackkrida  路  4Comments

nimishbongale picture nimishbongale  路  4Comments

Dhruvi16 picture Dhruvi16  路  4Comments

rajat2502 picture rajat2502  路  6Comments