Vocabulary: A smaller version of the header component [Feature request]

Created on 15 Jun 2020  路  8Comments  路  Source: creativecommons/vocabulary

Problem

The CC Search Extension mockup uses a header component that any of the current Vocabulary header component is not able to replicate. See the Figma Mockup file and a quick Codepen for reference.

Description

Some differences that I noticed:

  • The height of the header seems to be little larger than the one in the mockup.
  • The class of has-text-tomato class on nav-item links is not able to override the default nav-item color.
  • The nav-item also has larger margin and font-size.
  • Changing logomark icon with search icon does not work by default. Changing the viewBox attribute of svg element from 0 0 304 73 to 0 0 170 50 does the trick but now the icon is not vertically alligned.

Implementation

  • [ ] I would be interested in implementing this feature.
help wanted

Most helpful comment

Yes @makkoncept will open a pull request soon

All 8 comments

Hello @dhruvkb @makkoncept
If this issue is open I would like to take this up

Hello @dhruvkb
For the above mentioned changes is a new component need to be introduced or class has to mentioned for the desired changes
Please help
Thanks

Hello @dhruvkb
Can you please help

@kushaggarwal I would say you can use a class to transform the header instead of creating a new component.

The figma file has been moved. New link

Sure @hugosolar will follow the same
Thank you

@kushaggarwal are you still working on this?

Yes @makkoncept will open a pull request soon

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Dhruvi16 picture Dhruvi16  路  4Comments

obulat picture obulat  路  5Comments

zackkrida picture zackkrida  路  6Comments

zackkrida picture zackkrida  路  6Comments

obulat picture obulat  路  4Comments