Vocabulary: Remove fontawesome packages from Vue-Vocabulary

Created on 6 Nov 2020  路  4Comments  路  Source: creativecommons/vocabulary

Problem


After the final integration of SVG icons and documentation about them is over, I believe we can remove the following packages from Vue Vocabulary:

    "@fortawesome/fontawesome-svg-core": "^1.2.30",
    "@fortawesome/free-brands-svg-icons": "^5.14.0",
    "@fortawesome/free-regular-svg-icons": "^5.14.0",
    "@fortawesome/free-solid-svg-icons": "^5.14.0",
    "@fortawesome/vue-fontawesome": "^2.0.0",

Whenever we need an additional icon, we can always add its '.svg' source to the assets.

Implementation

  • [ ] I would be interested in implementing this feature.
good first issue help wanted improvement ready for work code medium

Most helpful comment

I think that we still need to polish SVG icon integration (i.e. path of fonts imports, icon styles) into Vocabulary before removing fontawesome packages, so this issue should be blocked for now.

All 4 comments

@obulat I would like to work on this issue.
Do I just need to remove
"@fortawesome/fontawesome-svg-core": "^1.2.30",
"@fortawesome/free-brands-svg-icons": "^5.14.0",
"@fortawesome/free-regular-svg-icons": "^5.14.0",
"@fortawesome/free-solid-svg-icons": "^5.14.0",
"@fortawesome/vue-fontawesome": "^2.0.0", from package.json

may i work on this?

@obulat @zackkrida I was the first one to claim the issue

I think that we still need to polish SVG icon integration (i.e. path of fonts imports, icon styles) into Vocabulary before removing fontawesome packages, so this issue should be blocked for now.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

zackkrida picture zackkrida  路  6Comments

panchovm picture panchovm  路  3Comments

zackkrida picture zackkrida  路  5Comments

obulat picture obulat  路  5Comments

zackkrida picture zackkrida  路  5Comments