Vm: Debug the startup script

[enoch85]

@szaimen

Just ran the latest VM and we have a major bug in there.

I don't know which commit that cause it, but we need to investigate like right now.

[enoch85]

I think it happens here: https://github.com/nextcloud/vm/blob/master/nextcloud-startup-script.sh#L358

[enoch85]

Please download the latest released VM and run the script and test all prompts.

I'll do the same.

Thanks!

[szaimen]

Please download the latest released VM and run the script and test all prompts.

I'll do the same.

Thanks!

I am on it 👍

[szaimen]

this looks like there is a '&' missing, no?
https://github.com/nextcloud/vm/blob/cbc20d1881f1341db2b8b231b83acfdc611278bb/nextcloud-startup-script.sh#L358
So that it results in
bash $SECURE && spinner_loading

[szaimen]

for me it looks like the failure was caused here:
https://github.com/nextcloud/vm/blob/cbc20d1881f1341db2b8b231b83acfdc611278bb/nextcloud-startup-script.sh#L367
But this worked in my testing... So I am not sure how to reproduce it...

[szaimen]

acutally together with the other failed commands it looks to me like the library wasn't successfully imported but this works for me.
What did you do to trigger this?

[szaimen]

It looks to me like this function never returns a failure:
https://github.com/nextcloud/vm/blob/cbc20d1881f1341db2b8b231b83acfdc611278bb/nextcloud-startup-script.sh#L69
So this just continues after a wait for 40 seconds and then just continues with the script without presenting you with the option to run the static_ip script... But I could be wrong...

[szaimen]

So I would change this:
https://github.com/nextcloud/vm/blob/cbc20d1881f1341db2b8b231b83acfdc611278bb/lib.sh#L827
to this:

if ! site_200 github.com
then
    return 1
fi

[szaimen]

Could you reproduce the issue? What are your findings?

[enoch85]

I ran the latest scripts on a VPS and the issue never came back.

Now I have to pick up my daughter in school so I can't continue right now. Sorry.

bash $SECURE & spinner_loading

No, that's correct as is.

What did you do to trigger this?

I first ran without internet, then connected it again, so maybe the startup script was using the local (old) lib?

[szaimen]

I ran the latest scripts on a VPS and the issue never came back.

Now I have to pick up my daughter in school so I can't continue right now. Sorry.

bash $SECURE & spinner_loading

No, that's correct as is.

okay 👍

What did you do to trigger this?

I first ran without internet, then connected it again, so maybe the startup script was using the local (old) lib?

hm, I'll have a look

[szaimen]

I tested without internet access and it fails to run the startup script as expected (and als runs static_ip as expected). So I cannot reproduce the issue. 🤷‍♂️

[enoch85]

I will test one more time, if we can't reproduce it I'll close.

[enoch85]

Not reproducible...

[enoch85]

I think it was my router that failed on me. I noticed the other day that it was bricked. I had to open it and replace the USB-drive with a new one.

Cause: internet went down during the script run.