Vite: Style Guide

[sno2]

Describe the solution you'd like
I think that we should try to implement a style guide to enforce cohesion amongst the files of this project. I have seen many different practices used inside of the code. Here are a couple of the things I would like to see inside of the style guide:

• https://github.com/denoland/deno/blob/v1.4.6/docs/contributing/style_guide.md#top-level-functions-should-not-use-arrow-syntax
• Obviously this one will take some work https://github.com/denoland/deno/blob/v1.4.6/docs/contributing/style_guide.md#use-jsdoc-for-exported-symbols
• https://github.com/denoland/deno/blob/v1.4.6/docs/contributing/style_guide.md#exported-functions-max-2-args-put-the-rest-into-an-options-object
• https://github.com/denoland/deno/blob/v1.4.6/docs/contributing/style_guide.md#exported-functions-max-2-args-put-the-rest-into-an-options-object
• https://github.com/airbnb/javascript#references--prefer-const
• https://github.com/airbnb/javascript#references--disallow-var
• I think we should force omitting the return statement for one line function bodies https://github.com/airbnb/javascript#arrays--callback-return
• https://github.com/airbnb/javascript#destructuring
• https://github.com/airbnb/javascript#strings
• using type defs on named iterators (for...of, forEach)
• use for...of instead of forEach (I'm biased and this needs to be discussed)
• use default value instead of typescript optional declaration (based upon the code I've seen this is the most used)

Obviously, this isn't enough for a complete style guide for every single thing, but it would be nice if the contributing guide included snippets of the important things to stay consistent with. Thanks for reading!

[yyx990803]

I personally don't find the level of strictness you suggest would really improve objective quality of the code - I can think of many cases where I'd have to work around them.

Some of them we can consider adopting:

• Prefer function declarations for top level functions
• JSDoc for exported symbols is a good thing to work on though (and it's not really a style rule).