Visualstudio: Comments added to a line in diff are not displaying in VS

[tierninho]

I added some new comments in a diff via inline comments, it was working fine until one certain line did not display the latest comment, even though it showed up on dotcom fine.

When you try adding a comment to line 5, it just disappears in VS.

Public repo:
https://github.com/tierninho-tester/TestRepo/pull/1

Build: 2.3.0.18

[jcansdale]

Are you sure https://github.com/tierninho-tester/TestRepo/ is public? I'm getting a 404.

[tierninho]

You are right... fixed it.

On Thu, Aug 17, 2017 at 9:50 AM, Jamie Cansdale [e-mail]
wrote:

Are you sure https://github.com/tierninho-tester/TestRepo/ is public? I'm
getting a 404.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/github/VisualStudio/issues/1149#issuecomment-323079363,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOJCl7uXpqHeI8nWodYWS56LN7JoY7JRks5sZEUpgaJpZM4O6SUI
.

--
Tiernan Lee
Quality Engineer
GitHub

[jcansdale]

Yup, I'm getting the same here. 😢

[tierninho]

Curious about the logic... if the file is only occupied on 5 of the 7 available lines as two are blank, then is the user limited to 5 comments total? It might explain the limit of 5 comment threads.

[shana]

Same here. Comment box is empty after submitting, no icon or comment shows up.

Comment count is not updated on the changes list either (PopupWindow.cs file)

[jcansdale]

@tierninho @shana You should find this is fixed in #1178.

It was choking when if found a partial match (e.g. the sdf line above) and giving up. It now knows how to continue looking for a full match.

[meaghanlewis]

I'm not observing this happening anymore 👍