Video-hub-app: Windows 10 maximize, close, reopen position incorrect

[whyboris]

On Windows 10:

1. maximize app
2. close app
3. open app
4. observe that the top bar extends above the screen, making the close/maximize/minimize buttons harder to press.

Should fix 😅 💦

[martincaron]

Tested on Windows 10, but observed a different behavior :

After executing step #1, steps #2 and #3 are not necessary to observe behavior in #4

I'll take a stab at it, hopefully i'm not working on something different.

[martincaron]

Disregard the previous comment about a different behavior. I got mixed up. I can reproduce the same behavior.

I think it may be considering the window frame when exporting the bounds to save.

[whyboris]

I'm pretty sure everything was working in version 1.0.0 -- so since then, perhaps Electron changed its behavior, or a new version of Windows causes trouble 🤷‍♂️ ... just guesses here -- I've spent 0 time so far looking into the issue 😅

I'll take a look if you'd prefer to work on something else 🤝

[martincaron]

Got this working in Windows 10. Looks like it was a combination of two factors :

• Frameless BrowserWindow
• Exporting/Saving the bounds on exit included the frame pixels. (Maybe Electron changed the way it exports bounds 🤷‍♂️)

I'll submit a PR

[whyboris]

Thank you @martincaron for the fix 🙇‍♂️🎖🎉 #425