Video-hub-app: Thumbnail Generation Issues

[cal2195]

Some files are still having problems generating thumbnails and/or video previews! 👎

This issue is to track down the (likely multiple) issues!

Problematic files:
1) .wmv files - Some of these files have their 0th stream be a mjpeg with 90k fps??
We should be using the 2nd stream, wmv. Will have to see if it's all wmv, or just some badly encoded ones...

I will add more details as I deal with each problematic file!

[whyboris]

Thank you for your continued debugging work.

I wonder if there's anything to be learned by looking at how fluent-ffmpeg does things? I used the library before and it seemed to handle all the edge cases (as far as I can tell).

Is there a chance there is no universal way to ask ffmpeg to extract screenshots without having to resort to checking various cases?

[cal2195]

Good thinking, Batman! 👍 Looks like they have some more logic that should fix issue 1. up there! 🎉

I'll look into implementing the edge-cases they deal with! 👍

[whyboris]

I don't think this is directly relevant, but it seems like a cool read anyway: Learn ffmpeg the hard way

[cal2195]

Regarding problem 1, this is only applicable to wmv file created in Windows Movie Maker - see https://trac.ffmpeg.org/ticket/1714

I am unsure if we should bother fixing this.. more thought is needed! 💡

[whyboris]

I'm _ok_ with leaving edge cases as is. If there's just a way not to have the app crash while extracting (whenever an error arises) we're good to go 🌊

[cal2195]

Fixed with #128! 🎉