Vgstation13: wonderful wardrobe has no sanity checks

[Accipitermaris]

Description of issue

that dang thing has vamp masks in it and shit

(gamemode was autotraitor, vox became vamp via the mask)

[Allspice]

why don't we just remove the fucking birds already yo

[jknpj]

vox gets free antag and a mask of spider queen in the same round

@Kurfursten seems like spessmart in a locker wasn't a good idea after all

[Sooose]

Traders getting a free roll at vamp round start seems a little silly, doesn't exactly require any effort.

[DamianX]

I think this was discussed in the PR that added it. Getting cool antag items was apparently okay because you could also get bad things (like a real facehugger, and ??? what else?). The obvious solution is to make the masks not work on traders so that they have to sell them :)

[Dacendeth]

add a blacklist and double the clothes that come out, so maybe just once the birds will have a matching set of cool plasmaman suits to buy.

[SonixApache]

i like the idea of making the masks not work on traders (or even better, vox in general)

[Kurfursten]

That's not what sanity means 🤔

[DamianX]

INSANE loot inside

[Durgen]

What are the chances of a vamp mask coming up?

[Kurfursten]

(1/all clothing items)*20

[Exxion]

Apparently there already is a blacklist
It uses exactly the same list of clothing that Spacemart does
This excludes the infinite vamp mask, but (apparently intentionally) not the one-use one

[Kurfursten]

Yep, that's how it was made. To be clear I don't really have strong feelings about this one way or the other. Though maybe all antag clothing should be taken off the spessmart masterlist instead of creating a second snowflake list. I mean, they only cost $150 at the store.

[Kurfursten]

I did some quick maffs based on the length of the all clothing item list and estimate our clothing items somewhere in the ballpark of 1200, which makes the chances of rolling any one particular item about 1.6% per shift you buy the wardrobe. Someone who wants a more accurate count can open the create object menu in the game panel and by hand count all /item/clothing.

[Durgen]

that seems like low enough rarity that it isn't actually a problem

[Accipitermaris]

It also has the Nuke Ops Holochip which a Vox Trader used to loot the Nuke Ops shuttle one round.

Pretty funny, but I think if people knew that this sort of stuff was going to be in the code for good they probably wouldn't have been as supportive of it. I can't really think of any other jobs in SS13 that we would give a similar "free pass" to, code wise.

[SonixApache]

Honestly, with how dull rounds can be, we might as well leave it in. Just a shame that the birds are infinitely more likely to use the item itself than they are to just trade it.

[Allspice]

this reminds me of when bags of holding were removed from the trader vend because they didn't have an incentive to trade it