Our current embedded lists arbitrarily render 6 elements by default.
We should add a custom parameter to define how many elements the list will render.
@txau @konzz @daneryl
How do we want to accomplish this? Our custom markup needs to be intuitive within its already difficult syntax.
Options include:
Any other ideas? Implementing this is not really hard, but finding the right solution may require some brainstorming.
Rafa.
I like the second option for no particular reason.
I'm in for the second option too.
The other option is to add a second paranthesis:
@RafaPolit I like the last one, as an optional parameter and with support for more params in the future.
That last option you presented looks cleaner, lets go for that one. Also the order of the params could be arbitrary so {list}(limit: 12)(very..long...url) could work as well.
Lets not make it arbitrary just yet to avoid logic to 'figure out' which parenthesis is first for now. If it is really necessary, we can add a further issue to improve on the system.
So, the Pull Request is ready to merge. For the person doing the QA, the way to test this is to add a second parenthesis (with no spaces) with the label limit and a number appended (again, with no spaces) to the list markdown escape code.
Example:
{list}(https://localhost:3000/en/)(limit:9)
It still needs to be in a single line, and with no spaces.
@kjantin I guess we need to add this to the docs
Most helpful comment
Lets not make it arbitrary just yet to avoid logic to 'figure out' which parenthesis is first for now. If it is really necessary, we can add a further issue to improve on the system.
So, the Pull Request is ready to merge. For the person doing the QA, the way to test this is to add a second parenthesis (with no spaces) with the label limit and a number appended (again, with no spaces) to the list markdown escape code.
Example:
It still needs to be in a single line, and with no spaces.